PR (Issue #1176) - Stop Forcing -gpu host on android emulators #1177
Conversation
…meters when launching an emulator (non headless mode)
…he android emulator gpu mode
|
@rotemmiz, looks good to me. Shall we merge? |
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
@RyanThomas73 for backwards compatibility, please return host as the default.
There was a problem hiding this comment.
@d4vidi Returning host as the default reintroduces the problem where it will always include -gpu host with the emulator command preventing the emulator command from honoring an explicit gpu mode specific in the emulator config via hw.gpu.mode=
There was a problem hiding this comment.
We could choose a specific value to map to undefined so it uses the emulator config default (e.g. detox test .... --gpu default) but I feel its better the way it is in the PR now. The user shouldn't have to explicitly specify default to get the default behavior from the emulator.
There was a problem hiding this comment.
Yes, you are right - I was not aware of that.
Nevertheless the issue of back-compatibility still is concerning (keeping the community happy). That being said, I take it that the crucial use cases are of the CI, where typically emulators are run headless, which isn't affected in this case. So, bottom line here - I'll approve and merge.
Thank you :)
Resolves #1176
Only adds the
-gpu [gpu mode]flags to the androidemulatorcommand if the--headlessparameter is specified or if an explicit--gpu [gpu mode]cli argument is provided.