-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce kotlin and reimplement RN-timers idling resource #1085
Conversation
NOTE still need to check the effect kotiln would have on a potential detox |
795cc63
to
b7db06c
Compare
b7db06c
to
f020871
Compare
Follow-up on the notes: Seems there are plenty of Kotlin based As for versioning -- I worked out detox to default to |
Next up, we have the CI saying: |
@rotemmiz you oughta change the project's settings to deny merging as long as checks haven't succeeded + view approved... |
@d4vidi Maybe related to this? https://shift.infinite.red/could-not-find-com-tools-build-gradle-2-3-3-8f586ad813ab |
f020871
to
368ebff
Compare
@yershalom holy c***, giving it a try... |
1366d8f
to
d26cbc7
Compare
d26cbc7
to
6e79f94
Compare
@d4vidi what's the verdict? Were you able to solve it? |
@rotemmiz ios builds fail in very weird ways. I'm trying to figure where this is coming from, though in essence this PR has nothing to do with iOS at all. |
@yershalom connectivity issues? -
'only other thing I can think of is changing the ver to 10.0.0, but that shouldn't matter, should it? |
I know what this is about. I'm taking care of it. |
a1cc05e
to
93d6e33
Compare
93d6e33
to
dc20527
Compare
Fixes issue #1115 |
Description:
ReactNativeTimersIdlingResource
in Kotlin, TDD.