Android: Increase RN-timers idling resources look-ahead to 1.5sec #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
changed the title
d4vidi
force-pushed
the
timers-ir-1500-ms
branch
from
4cf56f8
to
0ef1ef6
Compare
rotemmiz
reviewed
Nov 13, 2018
| final int intervalMS = nextTimerReflected.field(TIMER_FIELD_INTERVAL).get(); | ||
| final boolean isRepetitive = nextTimerReflected.field(TIMER_FIELD_REPETITIVE).get(); | ||
|
|
||
| // Log.i(LOG_TAG, "Next timer has duration of: " + intervalMS |
There was a problem hiding this comment.
Not sure those comments are necessary, unless there's a hack that needs an explanation.
There was a problem hiding this comment.
Assuming you're referring to the comments and not the logs -
they're necessary because we didn't unit test, so there's nothing here to explain the idea behind the implementation. This will change soon, of course.
|
@rotemmiz why not rebase over master, instead? |
|
Anyways this branch is becoming stale. If you're not comfortable with the code, let's try to think of smt else :) |
|
We're going to squash it anyway, it doesn't matter. But build is still red. |
|
Retriggerd the build, let's see |
|
Cool, tnx :) |
rotemmiz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rotemmiz just for review, don't merge