Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: force matchers to ignore layouts with GONE visibility #761

Closed
rotemmiz opened this issue May 30, 2018 · 0 comments · Fixed by #775
Closed

Android: force matchers to ignore layouts with GONE visibility #761

rotemmiz opened this issue May 30, 2018 · 0 comments · Fixed by #775
Assignees
@rotemmiz
Labels
status: accepted type: bug 🐞

Comments

@rotemmiz
Copy link
Member

If two labels/ids exist with the same name, where one is gone and other is visible, android matchers will match both, and throw multiple match error.
Add visibility check to matched views in
https://github.com/wix/detox/blob/master/detox/android/detox/src/main/java/com/wix/detox/espresso/DetoxMatcher.java#L35
@rotemmiz rotemmiz self-assigned this May 30, 2018
@guyca guyca mentioned this issue May 30, 2018
Closed
rotemmiz added a commit that referenced this issue Jun 6, 2018
@rotemmiz
Android: force matchers to ignore layouts with GONE visibility, closes …
f1facdb 
…#761
@rotemmiz rotemmiz mentioned this issue Jun 6, 2018
Merged
rotemmiz added a commit that referenced this issue Jun 6, 2018
@rotemmiz
Android: force matchers to ignore layouts with GONE visibility, closes …
a4b7e76 
…#761 (#775)
rotemmiz added a commit that referenced this issue Jun 10, 2018
@rotemmiz
Match only visible views (#780)
b9a832f 
* Android: force matchers to ignore layouts with GONE visibility, closes #761

* filter out views with effective visibility different than VISIBLE
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rotemmiz rotemmiz

Labels
status: accepted type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Android: force matchers to ignore layouts with GONE visibility wix/Detox
2 participants
@rotemmiz @d4vidi