Merge pull request #493 from wix/add-quotes-to-help-debugging

Add quotes around xcode version output
wix · Jan 7, 2018 · d93d984 · d93d984
2 parents 259a903 + 03132ff
commit d93d984
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/detox/src/devices/AppleSimUtils.js b/detox/src/devices/AppleSimUtils.js
@@ -149,7 +149,7 @@ class AppleSimUtils {
     const match = /^Xcode (\S+)\.*\S*\s*/.exec(stdout);
     const majorVersion = parseInt(_.get(match, '[1]'));
     if (!_.isInteger(majorVersion) || majorVersion < 1) {
-      throw new Error(`Can't read Xcode version, got: ${stdout}`);
+      throw new Error(`Can't read Xcode version, got: '${stdout}'`);
     }
     return majorVersion;
   }

diff --git a/detox/src/devices/AppleSimUtils.test.js b/detox/src/devices/AppleSimUtils.test.js
@@ -190,7 +190,7 @@ describe('AppleSimUtils', () => {
         await uut.getXcodeVersion();
         fail(`should throw`);
       } catch (e) {
-        expect(e).toEqual(new Error(`Can't read Xcode version, got: undefined`));
+        expect(e).toEqual(new Error(`Can't read Xcode version, got: 'undefined'`));
       }
     });
 
@@ -200,7 +200,7 @@ describe('AppleSimUtils', () => {
         await uut.getXcodeVersion();
         fail(`should throw`);
       } catch (e) {
-        expect(e).toEqual(new Error(`Can't read Xcode version, got: Xcode bla`));
+        expect(e).toEqual(new Error(`Can't read Xcode version, got: 'Xcode bla'`));
       }
     });
   });