Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: rt-template with in-place child component (not a function) #214

Open
yatra9 opened this issue Mar 6, 2017 · 2 comments

Comments

@yatra9
Copy link

yatra9 commented Mar 6, 2017

Hello.

It would be nice if rt-template has a option to put a React component itself (not a function) as a child property.

I use Microsoft's WinJS toolkit through react-winjs.
Some react-winjs components require other renderable React components as their properties.

For example, the ReactWinJS.SplitView of this sample code has child properties paneComponent and contentComponent which are also React components.

For example, rt-template with in-place property (instead of arguments property) makes sense?

<ReactWinJS.SplitView
  id={splitViewId}
  <rt-template prop="paneComponent" in-place />
     <div>...</div>
  </rt-template>
  <rt-template prop="contentComponent" in-place />
     <h2 className="win-h2" >{this.state.content}</h2>
  </rt-template>
</ReactWinJS.SplitView>
@nippur72
Copy link
Contributor

nippur72 commented Mar 6, 2017

Yes, this is something we really need if we want to talk with other libraries (WinJs but also MaterialUI, Antd etc). We discussed it in various places, see #209, #103, #150 and #155.

@yatra9
Copy link
Author

yatra9 commented Mar 7, 2017

Sorry for duplicate issue. I was not aware of those.

By the way, the tag name rt-template is a little bit weird, I think.
rt-inject or rt-modify etc. would be fit better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants