Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use _() in rt-class helper #179

Closed
nippur72 opened this issue Aug 3, 2016 · 0 comments
Closed

do not use _() in rt-class helper #179

nippur72 opened this issue Aug 3, 2016 · 0 comments

Comments

@nippur72
Copy link
Contributor

nippur72 commented Aug 3, 2016

rt-class now results in a call to _() (lodash function) to be generated.

This cause two possible issues:

  • templates not working due to incorrect lodash import with babel (as discussed in fixed rt-class to also work with lodash 4.5.0 #110)
  • it's no longer possible to isolate the only lodash methods used by react-templates (e.g. by making a custom build of lodash).

This can be fixed easily by changing _(...).transform( into _.transform(...,.
nippur72 added a commit to nippur72/react-templates that referenced this issue Aug 3, 2016
@nippur72
do not use _() in rt-class, fixes wix-incubator#179
97ed342
@idok idok closed this as completed in 9dbff14 Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nippur72