-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better rt-scope syntax parsing #175
Comments
cherry picked |
@idok can you please comment about the remaining features in my PR? will they be merged or can I consider them rejected? do you want me to isolate them so that they have no merge conflicts? |
@nippur72 first I want to apologise for the delay in reviewing your work. |
@idok thanks. Regarding |
Currently the syntax parsing for
rt-scope
is quite weak not allowing templates like the following:The problem lies in expressions containing
" as "
and";"
because those are also delimiters used to scan tokens in thert-scope
attribute.I think that can be slightly improved by having a proper regex that looks for the substring
" as id;"
whereid
is a valid JavaScript identifier and;
is optional.Hopefully that should lower the risk of keyword clashing.
The text was updated successfully, but these errors were encountered: