Skip to content

fix: change image writing method to synchronous for improved reliability #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: change image writing method to synchronous for improved reliability #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8619c
chore: bump version to 2.4.2
Tommytrg Jun 27, 2025
5408197
fix: change image writing method to synchronous for improved reliability
Tommytrg Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "witnet.io",
"private": true,
"version": "2.4.1",
"version": "2.4.2",
"type": "module",
"scripts": {
"build": "nuxt build",
Expand Down
8 changes: 1 addition & 7 deletions server/api/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,7 @@ async function downloadImages(items: Array<{ bannerImage: string }>) {
return response.arrayBuffer()
})
.then((arrayBuffer) => {
// Don't use fs.writeFileSync because it will block the event loop
// and cause performance issues
fs.writeFile(filePath, Buffer.from(arrayBuffer), {}, (err) => {
if (err) {
console.error('Error writing image to cache:', err)
}
})
fs.writeFileSync(filePath, Buffer.from(arrayBuffer), {})
return `/api/image/${hash}${ext}`
})
.catch((err) => {
Expand Down