Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Restrict sign ups to GitHub, work on UX #5172

Merged
merged 5 commits into from
Jun 25, 2019
Merged

Restrict sign ups to GitHub, work on UX #5172

merged 5 commits into from
Jun 25, 2019

Conversation

brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • api
  • hyperion (frontend)

@brianlovin
Copy link
Contributor Author

@mxstbr this is going to be hard to get right, so please poke around and help me identify where this flow is confusing.

The key changes:

  • we reject new users created in the API if the providerMethod is not GitHub. If it's the case that a user is trying to create a new account with another provider, it will redirect the user to /new/user. On this view, we now render a "sign up" screen if the user is not signed in - the only option provided is GitHub. There is an escape hatch back to /login where all signup methods are available for existing users.

Please review carefully and leave feedback! We can follow up later with in-app upsells for people to connect existing non-GitHub authed accounts with a GitHub profile.

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I really like how this works, great work! Quick bug reports:

  1. Being unauthenticated, going to a community view, then clicking "Join", and then clicking "Sign up" leads to this state, the modal does not close correctly: (also, the header text should match the button text with "Log in")

Screenshot 2019-06-21 at 09 00 12

  1. Am I correct in assuming this removes support for custom login screens?

Some communities are going to be a bit mad—we should link to a "FAQ" section next to this blurb that (in abstract terms) explains why signups are restricted.

Screenshot 2019-06-21 at 08 59 02

@brianlovin
Copy link
Contributor Author

@mxstbr ready for re-review. I've updated /:communitySlug/login and the login modal behavior.

mxstbr
mxstbr previously approved these changes Jun 25, 2019
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianlovin brianlovin marked this pull request as ready for review June 25, 2019 12:26
@brianlovin brianlovin merged commit edaf0cb into alpha Jun 25, 2019
@brianlovin brianlovin deleted the github-signups branch June 25, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants