-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Restrict sign ups to GitHub, work on UX #5172
Conversation
@mxstbr this is going to be hard to get right, so please poke around and help me identify where this flow is confusing. The key changes:
Please review carefully and leave feedback! We can follow up later with in-app upsells for people to connect existing non-GitHub authed accounts with a GitHub profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow I really like how this works, great work! Quick bug reports:
- Being unauthenticated, going to a community view, then clicking "Join", and then clicking "Sign up" leads to this state, the modal does not close correctly: (also, the header text should match the button text with "Log in")
- Am I correct in assuming this removes support for custom login screens?
Some communities are going to be a bit mad—we should link to a "FAQ" section next to this blurb that (in abstract terms) explains why signups are restricted.
@mxstbr ready for re-review. I've updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Status
Deploy after merge (delete what needn't be deployed)