Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

add auto scroll to thread #5118

Merged
merged 3 commits into from
May 23, 2019
Merged

Conversation

tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented May 20, 2019

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

Related issues (delete if you don't know of any)
Closes #5108

@spectrum-bot
Copy link

spectrum-bot bot commented May 20, 2019

Warnings
⚠️

These modified files do not have Flow enabled:

  • src/views/threadSlider/index.js

Generated by 🚫 dangerJS

@brianlovin
Copy link
Contributor

@tanmoyopenroot this is looking much better! one thing that it breaks, however, is the ability to close the thread modal by clicking on the overlay. Is it possible to resolve that?

@tanmoyopenroot
Copy link
Contributor Author

@brianlovin, the issue related to the outside click of the thread modal has been fixed.

Copy link
Contributor

@brianlovin brianlovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you again @tanmoyopenroot 🤗

@brianlovin brianlovin merged commit c3fd5a4 into withspectrum:alpha May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat popup doesn't have scrollbar instead uses main screen's scrollbar.
2 participants