This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Create new code block on space #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliankrispel
previously requested changes
Apr 13, 2018
| const text = currentBlock.getText(); | ||
| const type = currentBlock.getType(); | ||
| if (type !== "code-block" && CODE_BLOCK_REGEX.test(text)) | ||
| newEditorState = handleNewCodeBlock(editorState); |
There was a problem hiding this comment.
if it's a feature it makes sense to add it to the test harness imo
|
Good call, thanks for keeping me in check! Does that test case look good to you? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't require enter to create new code blocks, which solves a couple QoL issues. Ref withspectrum/spectrum#2854
/cc @brianlovin