Skip to content

Repository navigation

feat(admin): full-screen entry editor layout #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nasyrov merged 3 commits into from
Apr 24, 2026
Merged

feat(admin): full-screen entry editor layout #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c3c387
feat(admin): full-screen entry editor layout
nasyrov Apr 24, 2026
0fc0d26
refactor(admin,core): rail meta boxes as accordion sections; deprecat…
nasyrov Apr 24, 2026
cb13ba7
refactor(admin): address review findings on the entry editor layout
nasyrov Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/admin/e2e/content.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ test.describe("/entries/$slug/new", () => {
});

await page.goto("entries/posts/new");
await expect(page.getByTestId("post-editor-new-heading")).toBeVisible();
await expect(page.getByTestId("post-editor-headline")).toBeVisible();

// Auto-slug from title while slug is still unlocked.
await page.getByTestId("post-editor-title-input").fill("Hello World");
Expand Down Expand Up @@ -393,7 +393,7 @@ test.describe("/entries/$slug/new", () => {
}) => {
await mockRpc(page, { "/auth/session": AUTHED_ADMIN });
await page.goto("entries/posts/new");
await expect(page.getByTestId("post-editor-new-heading")).toBeVisible();
await expect(page.getByTestId("post-editor-headline")).toBeVisible();
await expectNoAxeViolations(page);
});
});
Expand Down Expand Up @@ -475,7 +475,7 @@ test.describe("/entries/$slug/$id", () => {
});

await page.goto("entries/posts/7");
await expect(page.getByTestId("post-editor-edit-heading")).toBeVisible();
await expect(page.getByTestId("post-editor-headline")).toBeVisible();
// Existing title populates from the loaded post.
await expect(page.getByTestId("post-editor-title-input")).toHaveValue(
"Original title",
Expand All @@ -499,25 +499,25 @@ test.describe("/entries/$slug/$id", () => {
});

test.describe("meta-box sidebar", () => {
test("renders side + normal boxes, fields are typable", async ({ page }) => {
test("all meta boxes render in the rail, fields are typable", async ({
page,
}) => {
await mockManifest(page, MANIFEST_WITH_META_BOXES);
await mockRpc(page, { "/auth/session": AUTHED_ADMIN });
await page.goto("entries/posts/new");

// Both boxes render — one in the side rail, one in the main column.
await expect(page.getByTestId("meta-box-seo")).toBeVisible();
await expect(page.getByTestId("meta-box-featured")).toBeVisible();
// Side rail container picks up only side-context boxes.
const sideRail = page.getByTestId("meta-boxes-sidebar");
await expect(sideRail.getByTestId("meta-box-featured")).toBeVisible();
await expect(sideRail.getByTestId("meta-box-seo")).toHaveCount(0);
// Full-screen editor: every registered meta box lands in the right
// rail. `box.location` is no longer honoured — all boxes are rail.
const rail = page.getByTestId("meta-boxes-sidebar");
await expect(rail.getByTestId("meta-box-seo")).toBeVisible();
await expect(rail.getByTestId("meta-box-featured")).toBeVisible();

// Text field in the normal box accepts input.
// Text field in the seo box accepts input.
const metaTitle = page.getByTestId("meta-box-field-meta_title-input");
await metaTitle.fill("Hello meta");
await expect(metaTitle).toHaveValue("Hello meta");

// Checkbox in the side box toggles.
// Checkbox in the featured box toggles.
const featured = page.getByTestId("meta-box-field-is_featured-input");
await expect(featured).not.toBeChecked();
await featured.check();
Expand Down
Loading
Loading