-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add phpunit
completion spec
#1824
Conversation
Added my contribution of phpunit
Add files via upload
Add files via upload
Fixed the syntax of the completion specs and added args to them
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Overviewsrc/phpunit.ts:Info: |
Hello @rubynguyen1510,
Please add a 👍 as a reaction to this comment to show that you read this. |
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
phpunit.ts
Outdated
@@ -0,0 +1,245 @@ | |||
const completionSpec: Fig.Spec = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rubynguyen1510, can you fix the two highlighted issues, then we can merge it!
src/phpunit.ts
Outdated
}, | ||
}, | ||
{ | ||
name: "--coverage-text=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: "--coverage-text=", | |
name: "--coverage-text", | |
requiresSeparator: true, |
deleted: phpunit.ts modified: src/phpunit.ts
Hello Fig team! I already changed the code as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.