Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add phpunit completion spec #1824

Merged
merged 17 commits into from
Feb 14, 2023
Merged

Conversation

rubynguyen1510
Copy link
Contributor

No description provided.

@withfig-bot
Copy link
Collaborator

withfig-bot commented Jan 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

Overview

src/phpunit.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @rubynguyen1510,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@rubynguyen1510
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@SimplyMiguel
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

phpunit.ts Outdated
@@ -0,0 +1,245 @@
const completionSpec: Fig.Spec = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted

@fedeci fedeci changed the title Add phpunit completion specs feat: add phpunit completion spec Feb 6, 2023
Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rubynguyen1510, can you fix the two highlighted issues, then we can merge it!

src/phpunit.ts Outdated
},
},
{
name: "--coverage-text=",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "--coverage-text=",
name: "--coverage-text",
requiresSeparator: true,

	deleted:    phpunit.ts
	modified:   src/phpunit.ts
withfig-bot added a commit that referenced this pull request Feb 12, 2023
@rubynguyen1510
Copy link
Contributor Author

Hello Fig team! I already changed the code as requested.

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedeci fedeci merged commit ac87486 into withfig:master Feb 14, 2023
@withfig withfig locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants