Repository navigation
Astro 7 support #3951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Astro 7 support #3951
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
daea539
feat: update to `beta.3`
HiDeoo a4dccbe
feat: remove badge and icon trailing whitespace workaround
HiDeoo 0459d9b
test: update anchor headings test
HiDeoo 5624478
docs: remove outdated banner
HiDeoo 76bafd6
docs: add upgrade banner
HiDeoo 73271ee
chore: tweak some comments
HiDeoo f94b906
chore: update various packages
HiDeoo 0df3f22
feat: experiment with lazy barrel optimization
HiDeoo 85cf5ac
Merge branch 'main' into hd/feat-astro-7
HiDeoo b88da64
chore: add changeset
HiDeoo 49f42aa
chore: update browserlist query
HiDeoo e73b902
chore: format changeset
HiDeoo f6cd257
feat: update `@astrojs/node@11.0.0-beta.2`
HiDeoo 2d2f52b
refactor: `virtual-user-config` → `vite-virtual-modules`
HiDeoo df24995
feat: use satteri by default
HiDeoo 40d8456
feat: disable link validation
HiDeoo 6dbc2ab
refactor: `integration/` directory cleanup
HiDeoo 7587dff
Merge branch 'main' into hd/feat-astro-7
HiDeoo 0107788
feat: update to `beta.6`
HiDeoo 7af9692
fix: remove outdated todo
HiDeoo b991bbf
feat: update to stable astro packages
HiDeoo 7553fb2
feat: bump starlight required veresion in `@astrojs/starlight-markdoc`
HiDeoo cb29dc8
chore: cleanup `minimumReleaseAgeExclude`
HiDeoo 12f6aa6
feat: update `astro@7.0.2`
HiDeoo 73626e1
fix: more explicit `componentsBarrelIdFilter`
HiDeoo 423f7d2
test: `vitePluginStarlightLazyBarrelOptimization`
HiDeoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| '@astrojs/starlight': minor | ||
| --- | ||
|
|
||
| Adds support for Astro v7, drops support for Astro v6. | ||
|
|
||
| #### Upgrade Astro and dependencies | ||
|
|
||
| ⚠️ **BREAKING CHANGE:** Astro v6 is no longer supported. Make sure you [update Astro](https://docs.astro.build/en/guides/upgrade-to/v7/) and any other official integrations at the same time as updating Starlight: | ||
|
|
||
| ```sh | ||
| npx @astrojs/upgrade | ||
| ``` | ||
|
|
||
| _Community Starlight plugins and Astro integrations may also need to be manually updated to work with Astro v7. If you encounter any issues, please reach out to the plugin or integration author to see if it is a known issue or if an updated version is being worked on._ | ||
|
|
||
| ⚠️ **BREAKING CHANGE:** This release drops official support for Chromium-based browsers prior to version 111 (released 07 March 2023) and Safari-based browsers prior to version 16.4 (released 27 March 2023). You can find a list of currently supported browsers and their versions using this [browserslist query](https://browsersl.ist/#q=%3E+0.5%25%2C+not+dead%2C+Chrome+%3E%3D+111%2C+Edge+%3E%3D+111%2C+Firefox+%3E%3D+121%2C+Safari+%3E%3D+16.4%2C+iOS+%3E%3D+16.4%2C+not+op_mini+all). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| '@astrojs/starlight-markdoc': minor | ||
| --- | ||
|
|
||
| ⚠️ **BREAKING CHANGE:** The minimum supported version of Starlight is now 0.41.0 | ||
|
|
||
| Please use the `@astrojs/upgrade` command to upgrade your project: | ||
|
|
||
| ```sh | ||
| npx @astrojs/upgrade | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,6 @@ | |
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/starlight": "workspace:*", | ||
| "astro": "^6.4.5" | ||
| "astro": "^7.0.0" | ||
| } | ||
| } | ||
11 changes: 0 additions & 11 deletions
11
packages/starlight/__e2e__/fixtures/basics/src/components/Test.astro
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
packages/starlight/__e2e__/fixtures/basics/src/content/docs/whitespaces.mdx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,6 @@ | |
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/starlight": "workspace:*", | ||
| "astro": "^6.4.5" | ||
| "astro": "^7.0.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,6 @@ | |
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/starlight": "workspace:*", | ||
| "astro": "^6.4.5" | ||
| "astro": "^7.0.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,6 @@ | |
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/starlight": "workspace:*", | ||
| "astro": "^6.4.5" | ||
| "astro": "^7.0.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligns with Vite 8 default browser target changes and uses the
baseline-widely-availabletarget.In our case, the most impactful change seems to be the new range media query syntax (e.g.
@media (width >= 400px)) being used.If we ever want to avoid this, we would need to update the
build.targetVite configuration option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting 👀
I’m generally a little sceptical of Baseline (there can sometimes be important cases where older browsers are still in use, so the two-year cut-off is sometimes a bit arbitrary). But it doesn’t really make sense for Starlight to override the Vite default would be my guess. Happy to go with this and if we get feedback that people are hitting compatibility issues we can reconsider.