Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): Add small snippet about the inferRemoteSize function #8808

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

Princesseuh
Copy link
Member

Description (required)

Documentation for withastro/astro#11098

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 7d487c4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6698eac64856ce0008fc4096
😎 Deploy Preview https://deploy-preview-8808--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 15, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Looking good @Princesseuh ! I didn't want to edit directly over top of you, but I did want to access some other parts of this file. We can still figure out the best wording, but I wanted to make sure that we thought about other areas where we might want to reference this!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jul 16, 2024
@sarah11918
Copy link
Member

NOTE TO SELF: you can also use inferSize on getImage, so take a sweep and make sure nothing implies that you can't, and that this (more advanced) use case is at least mentioned.

@sarah11918 sarah11918 added this to the 4.12.0 milestone Jul 18, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.12.0 July 18, 2024 10:14
@sarah11918 sarah11918 merged commit ec1a023 into 4.12.0 Jul 18, 2024
1 check passed
@sarah11918 sarah11918 deleted the feat/infer-remote-function branch July 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants