Adapter enhancements in Astro 4.2 #6315
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sarah11918
added
add new content
Co-authored-by: Alex Nguyen <[email protected]>
VoxelMC
left a comment
VoxelMC
left a comment
There was a problem hiding this comment.
Hello!!
I know it's still a draft, but should we entertain the idea of having some Expressive Code here? Since we are not inlining the options in the function, it might be helpful if the eyes have somewhere to snap to!
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Just some minor polishing here, @lilnasy ! Not much work at all!
Just to double-triple check: did you also go through closely all the code examples on this page and update any that might be affected? (I don't see any updates/corrects in code, so does that mean we were good?)
|
Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: voxel!() <[email protected]>
|
There seems to be nothing else to update on the page. I do want to order |
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
@lilnasy Would love one final review from you on this, as I made some tiny adjustments (e.g. linked within-page to headings, and then linked those to other pages)
But on my end, this feels good to go!
sarah11918
added
the
Merge Queue
|
I was watching 👀. Love the edit around |
VoxelMC
left a comment
VoxelMC
left a comment
There was a problem hiding this comment.
Great work so far!
Just some cleanup here, let me know if it's incorrect at all!
* Adapter enhancements in Astro 4.2 * Apply suggestions from code review Co-authored-by: Alex Nguyen <[email protected]> * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: voxel!() <[email protected]> * routeData, locals -> locals, routeData * thanks for the complex punctuation Arsh * line spacing * explain/link what locals is before the example * line spacing * updates link strategy * fix link * fix more stupid links --------- Co-authored-by: Alex Nguyen <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: voxel!() <[email protected]>
Description (required)
Documents new options in the adapter API being introduced in Astro 4.2
Related issues & labels (optional)