[i18nIgnore] Integration READMEs in docs! #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah11918
added
the
site improvement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
added
the
i18n
VoxelMC
reviewed
Dec 20, 2023
VoxelMC
reviewed
Dec 20, 2023
Co-authored-by: Voxel <[email protected]>
dreyfus92
reviewed
Dec 20, 2023
src/content/docs/zh-cn/guides/integrations-guide/cloudflare.mdx
Outdated
Show resolved
Hide resolved
sarah11918
commented
Dec 20, 2023
Co-authored-by: Paul Valladares <[email protected]>
|
Amazing work catching these, @dreyfus92 ! 🚀 |
sarah11918
added
the
help - leave feedback
ElianCodes
approved these changes
Dec 21, 2023
Co-authored-by: Reuben Tier <[email protected]>
dreyfus92
approved these changes
Dec 21, 2023
1 task
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Voxel <[email protected]> Co-authored-by: Paul Valladares <[email protected]> Co-authored-by: Reuben Tier <[email protected]> Co-authored-by: = <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This performs all the
contentchanges required for the Integration READMEs :/en/page has updated frontmatter:- No more dev warning
-
githubURLchanged togithubIntegrationURLto separate logic forEditLink.astroandPageTitle.astro(Error messages and config-ref still need to usegithubURLfor off-site editing, but the integrations need a header link back to the package on GitHub, too.-
hasREADME: truedeleted/scripts/generate-integration-pages.tsso that this file is included. Will need Chris to review what changes (deletion?) needs to be made here.EditLink.astroended up with an extra blank line, but at least it's here for easy reference in case Chris decides he prefers to tackle this from that end, vs my strategy to updatePageTitle.astrologic.Tested behaviour:
Accompanying tasks outside of docs code:
remove CI task
Merge corresponding
withastro/astroandwithastro/adaptersPRs:Make current docs content changes corresponding to Not yet merged Solid feature
Make sure no new PRs are opened to integration/adapter READMES