Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): current locale #5410

Merged
merged 3 commits into from
Nov 21, 2023
Merged

feat(i18n): current locale #5410

merged 3 commits into from
Nov 21, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 14, 2023

Description (required)

This PR adds documentation for Astro.currentLocale

Related issues & labels (optional)

RFC change: withastro/roadmap@f934880

For Astro version: 3.5.*. See astro PR: withastro/astro#9101

We are in an experimental phase, so we can add new features in any release.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 5222480
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6553c659ad671f00086d218c
😎 Deploy Preview https://deploy-preview-5410--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico ematipico added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Nov 14, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ematipico ! I took a shot at simplifying the explanation, because I think we can remove some complication here (if I understand this correctly!)

Please let me know if the following is correct, and if so, I think it's OK just to say that!

src/content/docs/en/guides/internationalization.mdx Outdated Show resolved Hide resolved
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 21, 2023 3:03pm

@sarah11918 sarah11918 added minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! and removed minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Nov 15, 2023
@sarah11918
Copy link
Member

Note that this is set for 3.5.6... next release!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for the next patch release.

@sarah11918 sarah11918 merged commit d6a5a9c into main Nov 21, 2023
6 checks passed
@sarah11918 sarah11918 deleted the feat/current-locale branch November 21, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants