Skip to content

docs: Add mention of Picture and new srcset-related attributes#4866

Merged
sarah11918 merged 14 commits intomainfrom
feat/picture
Oct 12, 2023
Merged

docs: Add mention of Picture and new srcset-related attributes#4866
sarah11918 merged 14 commits intomainfrom
feat/picture

Conversation

@Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Sep 29, 2023

What kind of changes does this PR include?

  • New or updated content

Description

This is docs for withastro/roadmap#715.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4239f03
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/65280779a579f200084f05ff
😎 Deploy Preview https://deploy-preview-4866--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Oct 1, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finishing this "mostly done" review now! There are a couple of suggestions I've made for you to see if they make sense.

The only thing I haven't looked at really yet is the pictureAttributes which I think could benefit from an example on this page!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finishing this "mostly done" review now! There are a couple of suggestions I've made for you to see if they make sense.

The only thing I haven't looked at really yet is the pictureAttributes which I think could benefit from an example on this page!

Princesseuh and others added 2 commits October 11, 2023 13:48
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@Princesseuh Princesseuh changed the title docs: draft for Picture RFC docs: Add mention of Picture and new srcset-related attributes Oct 11, 2023
@Princesseuh Princesseuh marked this pull request as ready for review October 11, 2023 15:44
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful with so many helpful examples, @Princesseuh ! Can't wait for people to start using it!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small nit but then we're good 🙌

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 sarah11918 merged commit b91953c into main Oct 12, 2023
@sarah11918 sarah11918 deleted the feat/picture branch October 12, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants