Update Netifly Adapter Page#4859
Update Netifly Adapter Page#4859sarah11918 merged 13 commits intowithastro:mainfrom jacobdalamb:fix/netlify-docs
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ElianCodes
left a comment
ElianCodes
left a comment
There was a problem hiding this comment.
There's a broken link introduced in this PR, can you update that one too?
Thanks for the PR @jacobthesheep!
Co-authored-by: Elian ☕️ <hello@elian.codes>
yanthomasdev
changed the title
There was a problem hiding this comment.
Hi @jacobthesheep ! Thanks for jumping on this issue! It's true, our deploy pages don't always get as much updating as they should, and I guess Netlify would prefer we not call their stuff "experimental" anymore! 😄
I think we can tackle the other update a little more strategically, though, as we should consider this page being read by someone following these instructions for the first time. Most people only deploy once, and don't frequently revisit these instructions after they have already done so, so it's generally most helpful to just describe instructions as one would now follow them.
I've made suggestions below that I think can tackle this cleanly! See what you think!
|
@ElianCodes I think it's safe to remove the block, and you and @jacobthesheep can pick this one up with my feedback! |
|
(And, I had a bad autoname fill in on my earlier comment, so I'm sorry for an errant ping to someone not involved in this PR!) |
sarah11918
added
the
improve or update documentation
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
I think this PR can be closed as Houston has caught this #4965 |
sarah11918
dismissed
ElianCodes’s stale review
all ready to go now, including upstream
|
This PR should still go through! The ci only catches the config reference docs. The changes to the Netlify deploy guide still need to be applied via this PR. I'm updating and rerunning the checks, and will merge this, and the ci one together as soon as checks pass! 🙌 |
* i18n(ja): Update `/guides/deploy/netlify.mdx` * i18n(ja): Fix missing update of #4859 * i18n(ja): Fix anchor hash * Revert "i18n(ja): Fix anchor hash" This reverts commit e4a7d29. * i18n(ja): Fix to unify words * Fix link @tracker-major:./src/content/docs/ja/guides/deploy/netlify.mdx; --------- Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
* i18n(ja): Update `/guides/deploy/netlify.mdx` * i18n(ja): Fix missing update of #4859 * i18n(ja): Fix anchor hash * Revert "i18n(ja): Fix anchor hash" This reverts commit e4a7d29. * i18n(ja): Fix to unify words * Fix link @tracker-major:./src/content/docs/ja/guides/deploy/netlify.mdx; --------- Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
4 participants
What kind of changes does this PR include?
Description
Related Issue / Implementation PR
@astrojs/netlify#4812