-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] feat: change default port #3977
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a couple of changes, mostly generalising the use of http://localhost:4321
instead of localhost:4321
or https://localhost:4321
Sorry in advance 🤣
@ElianCodes I leave the task to merge the suggestions to you :) |
@ematipico allright! Can you confirm that the port will default to 4322 instead of 4321 when that port is occupied? |
Yes :) Same behaviour as before. Astro starts looking for the first port available, incrementally: 4321, 4322, 4323, etc. |
Hey @ematipico! I'm in the process of generalising the protocol. Gonna go through all of them one last time. When I'm done, I'll keep you posted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple of leftovers 😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I now should have all of them! Good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHEW! 😅
Assuming that there is otherwise no language changed here on any of the pages, just 3000
-> 4321
, then I'm approving this one as ready for v3!
(If there is anything other than that I should take a peek at, please point it out to me. Otherwise, this one just waits!)
@ElianCodes changed all the instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 IMPORTANT 🚨
Till this PR gets merged we will probably have more pages with localhost:3000
, especially in translations. From what I can see, this PR only changes the mentions of the port, no new docs added, so the final merge message should contain [i18nIgnore]
to avoid our tracker from marking these pages as 100% updated, and also rerun the search and replace to account for newer translations added.
@Yan-Thomas I'm changing most of these PRs to PR the upgrade guide v3 branch instead of main, so does that solve the above problem? Let me know how we should handle this one! Maybe an intentional rescan in that PR branch shortly before merging, and then we might catch all of them? |
No! Keep this PR to main, after the 3.0 PR is merged then update branch and search and replace |
What kind of changes does this PR include?
Description
This PR changes the default port to
4321
.Code PR: withastro/astro#7874
I only did a search and replace of
:3000
throughout the website. Let me know if the change is too disruptive and if I should change only a subset of pages.