Repository navigation
Document new emitClientAsset function - #13223
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Thanks for this, @matthewp !
(Will also tag in @ArmandPhilippot since I'm not sure whether it would be helpful to link out to the Rollup.* types? e.g. we show an example with type, name, and source, but not how someone is supposed to know what values they can use there.)
Just tried to edit the text to match our style a little more, but will need your help for some clarity on exactly what's happening and what (might be?) an implementation detail to know for sure!
Also, as mentioned in the Astro PR, the Cloudflare breaking change will need an entry on the Cloudflare adapter's own page since we've got a separate, specific upgrade guide for the Cloudflare major. That can be in this PR if you prefer, or a separate one! https://v6.docs.astro.build/en/guides/integrations-guide/cloudflare/#upgrading-to-v13-and-astro-6
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
I left a suggestion to handle Sarah's comment re: "I'm not sure whether it would be helpful to link out to the Rollup.* types?". When we have docs, I think this is helpful to add a link but unfortunately that's not always the case.
And two more suggestions:
- I think a link to Rollup in another place could be helpful
- I'm not sure what
thisis in the code snippet and we might need to add more context here (either in the code snippet or as a sentence to introduce it and explain whatthisis).
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Description (required)
emitClientAssetis a new function exported fromastro/assets/utilsthat's useful for integration authors that want to emit an asset that should be available in the client asset folder (such as images).Related issues & labels (optional)
For Astro version:
6.x. See astro PR #15345.