-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add Cloudflare Astro 6 docs #12981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudflare Astro 6 docs #12981
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Matt, this looks great! And well done with the upgrade guide! 🙌🏽
I left a few suggestions, most of them are nits and I expect you to weight on them as Cloudflare expert and native speaker to judge if this makes sense or not. 😅
The most important thing is your formatter which is messing with the API blocks... It would be better to revert these changes.
Otherwise, this looks to be in great shape to me!
|
@ascorbic I can see you have a bunch of comments from Armand and Alex, and I was going to wait until these were resolved to take a look here before looking into this one myself! If you'd rather we just handle it from here, but ping you if there are things we're unsure of, then let me know and we'll work that way! |
|
@ascorbic do you need any help with this PR? |
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
|
Thanks everyone for jumping in here! I've committed Yan's suggestions, and will give this a final read over before merging so that it's available to people ASAP! |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly syntax/light editing here, so I'm comfortable committing these! I've left comments for the ones that might need an explanation, or for future historical record/to demonstrate our choices.
If you catch something before I merge this, great! If not, we can update this page after the fact!
Description (required)
This PR updates the Cloudflare integration guide to use the new Astro 6 APIs. It also adds a migration guide for users moving from Astro 5 to 6. It includes some info about manually configuring Cloudflare Pages (which is no longer automatic), but it doesn't yet have a very good guide to migrate from Pages to Workers. It links out to the guide in the Cloudflare docs, but I'd like to add something more Astro-specific in a follow-up PR.
Related issues & labels (optional)