Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Dec 18, 2025

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #15006.

@florian-lefebvre florian-lefebvre added this to the v6.0.0 docs milestone Dec 18, 2025
@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 41ab00d
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69445793343be90008eb3948
😎 Deploy Preview https://deploy-preview-12951--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 18, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/sessions.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v6.mdx Localization changed, will be marked as complete.
en/reference/session-driver-reference.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review December 18, 2025 10:41
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and clear to me

@florian-lefebvre
Copy link
Member Author

One thing I would change maybe is: rename driver.options to driver.config to stay consistent with image services and font providers

@anaxite
Copy link
Contributor

anaxite commented Dec 18, 2025

Watched this on Talking and Doc'ing. Thank you!

@JusticeMatthew
Copy link
Contributor

T&D

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, Florian! 🙌🏽 I left two suggestions regarding the new sentences in "session driver config" and "session driver implementation". Maybe it's just me, but when the first words repeat the title, it sounds strange to me. Feel free to adapt them!

Co-authored-by: Armand Philippot <[email protected]>
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Dec 18, 2025
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic @florian-lefebvre ! Just a few nit thoughts from me, but this is pretty good to go! I'm happy when you're happy, but we can't merge until this is released in the next alpha.

Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918
Copy link
Member

I'll add merge queue to indicate I think we're all happy with this one! (But, merge on release takes precedence!!)

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 18, 2025
@sarah11918 sarah11918 merged commit 27adf43 into v6 Dec 18, 2025
10 checks passed
@sarah11918 sarah11918 deleted the feat/sessions-drivers-changes branch December 18, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants