Skip to content

Conversation

@ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Dec 10, 2025

Description (required)

Related issues & labels (optional)

  • Suggested label: add new content, improve or update documentation

@ArmandPhilippot ArmandPhilippot added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Dec 10, 2025
@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 333cabf
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69419be4e199dd000931ea6e
😎 Deploy Preview https://deploy-preview-12867--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 10, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-gatsby.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-nextjs.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-nuxtjs.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v3.mdx Source changed, localizations will be marked as outdated.
en/reference/image-service-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/modules/astro-assets.mdx Source changed, localizations will be marked as outdated.
ru/guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot
Copy link
Member Author

This should be ready to review now!

  • the TOC is a bit heavy now, but if we hide the h4 this would hide the <Image /> properties...
  • getImage() from astro/assets is internal code. I don't know if this is expected or if this should be the astro:assets version instead.

@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review December 13, 2025 18:59
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just a few comments here before we decide what to do about the table of contents!

This could mean showing fewer levels, I think this should include avoiding "Image properties" so we can just have the image component, then each property etc. and we might end up strategically hiding some of the "building an image service only" content.

We'll figure that out!

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 16, 2025
@ArmandPhilippot
Copy link
Member Author

I believe we would need this because of the ru file:

@lunaria-track:src/content/docs/en/**.mdx

https://lunaria.dev/guides/tracking/#lunaria-track

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview with the new h2 and h3 only looks good! Thanks for this amazing work, Armand!

@ArmandPhilippot ArmandPhilippot merged commit fa1260e into withastro:main Dec 16, 2025
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the fix/modules/astro-assets branch December 16, 2025 17:59
@ArmandPhilippot ArmandPhilippot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants