Skip to content

feat(fonts): merge families #12696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarah11918 merged 6 commits into from
Nov 13, 2025
Merged

feat(fonts): merge families #12696

sarah11918 merged 6 commits into from
Nov 13, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Nov 11, 2025

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.15.6. See astro PR #14750.

@florian-lefebvre florian-lefebvre mentioned this pull request Nov 11, 2025
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 11, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link

netlify bot commented Nov 11, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 25444de
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6915e90f94f0e100082aa931
😎 Deploy Preview https://deploy-preview-12696--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

sarah11918
sarah11918 reviewed Nov 11, 2025
View reviewed changes
sarah11918
sarah11918 reviewed Nov 12, 2025
View reviewed changes
@sarah11918
Copy link
Member

sarah11918 commented Nov 12, 2025

(Also noting it looks like the Astro PR is already merged and we didn't discuss its changeset!)

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! and removed minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Nov 12, 2025
@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Nov 13, 2025 •
edited
Loading

Oh I'm sorry! Since its a patch I completely forgot. We didn't released the ci PR yet so we can still edit the changeset (https://github.com/withastro/astro/blob/main/.changeset/tired-houses-sink.md)

florian-lefebvre and others added 2 commits November 13, 2025 08:56
@florian-lefebvre @sarah11918
Update src/content/docs/en/reference/experimental-flags/fonts.mdx
b475cd2 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@florian-lefebvre
Merge branch 'main' into feat/fonts-merge-families
73b2ee6
@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Nov 13, 2025

I slightly edited your suggestion

sarah11918
sarah11918 reviewed Nov 13, 2025
View reviewed changes
florian-lefebvre
florian-lefebvre commented Nov 13, 2025
View reviewed changes
florian-lefebvre
florian-lefebvre commented Nov 13, 2025
View reviewed changes
sarah11918
sarah11918 approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 merged commit 359c349 into main Nov 13, 2025
10 checks passed
@sarah11918 sarah11918 deleted the feat/fonts-merge-families branch November 13, 2025 15:48
@jsparkdev jsparkdev mentioned this pull request Nov 14, 2025
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Nov 14, 2025
@ArmandPhilippot
i18n(fr): update experimental-flags/fonts.mdx
2ce38ae 
See withastro#12696
@ArmandPhilippot ArmandPhilippot mentioned this pull request Nov 14, 2025
Merged
@maxchang3 maxchang3 mentioned this pull request Dec 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@florian-lefebvre @astrobot-houston @sarah11918