-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[i18nIgnore] Localized v6 link failures related to Astro.glob() #12616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say we could just remove the "See also:" from the translated errors because they seem up to date, but they translate the error itself so, yeah, it's probably better to remove them entirely!
LGTM!
|
Alright, thanks for the reviews! Let's watch some dominoes (hopefully) fall! |
This addresses some link failures in translations on the v6 branch because:
Astro.glob()is removed in v6, so some links that passed in current v5 docs (where it's still documented, though as deprecated) fail in v6 docs where this is removed entirely.