-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Document skew protection in Netlify adapter #12554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ac5b10a
Document skew protection in Netlify adapter
matthewp ae370e4
add version number
matthewp 73713f0
Merge branch 'main' into netlify-skew-protection
yanthomasdev 203de5c
docs: update AstroAdapter interface to include client configuration
matthewp 7a03723
Merge branch 'netlify-skew-protection' of github.com:withastro/docs i…
matthewp 62dd44b
docs: add assetQueryParams to AstroAdapter client configuration
matthewp 2d7fbde
Update src/content/docs/en/guides/integrations-guide/netlify.mdx
matthewp ce800ed
Merge branch 'main' into netlify-skew-protection
sarah11918 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is a 404 for me, and I can't seem to find anything quickly in Netlify's docs for skew protection. Do you have another link, Matthew?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They haven't published it yet, I'll send you the preview url later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Then no concerns as long as it's live by the time docs publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct link would be https://docs.netlify.com/deploy/deploy-overview/#skew-protection
This is a new section in an existing page, so it won't completely break. But I would aim to get it live on our end soon as you're ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eladroz ! We will be publishing the release today, and I see Matthew has removed the link entirely for now. We are happy to update the page as soon as the page is live, even if it's not included at time of publishing! We'll try to remember, but you're welcome to make a PR to this page directly at any time once the Netlify section is live on the page!