-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: update wrong link in live-content-config-error.mdx
#11915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update wrong link in live-content-config-error.mdx
#11915
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Approving, but we need to update the link in the core repo:
https://github.com/withastro/astro/blob/97c3c8a7221b6e5c3ebde0ad7350875ab8d0768c/packages/astro/src/core/errors/errors-data.ts#L1714
|
Thank you. I've opened a new PR. |
|
@jsparkdev @ArmandPhilippot Thank you both! just noting that for emergency fixes, we CAN merge a PR like this, as long as we make a corresponding one at source. That way, the fix is live immediately and the GitHub Action will just "catch up" eventually 😄 up to you whether you went to reopen & merge! |
|
Thank you. Let's open it again and merge it. |
Description (required)
update wrong link in
live-content-config-error.mdx