-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: update csp.mdx
#11850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update csp.mdx
#11850
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catches, @jsparkdev!
I just have a doubt regarding the order of script-src and style-src. Did you saw that by testing yourself?
Otherwise, all the other changes looks good to me!
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I was looking at the wrong place for the script-src/style-src order. So everything LGTM! Thanks! 🙌🏽
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the renaming etc. checks out with the code, thank you @jsparkdev !
I've asked about the one outstanding comment, and once that is resolved, this PR should be good to go!
|
Thank you all for your reviews. I've noticed myself that enabling If I'm right about the bug, I've requested a bug fix in withastro/astro#13905 and will update the documentation once it's merged. |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jsparkdev - amazing catches, as always!
Description (required)
Update incorrect order, method names, description formatting, etc.