Skip to content

Conversation

@jsparkdev
Copy link
Member

@jsparkdev jsparkdev commented Jun 6, 2025

Description (required)

Update incorrect order, method names, description formatting, etc.

@netlify
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20fed43
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/684634333e2b3a0008d99c14
😎 Deploy Preview https://deploy-preview-11850--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 6, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/csp.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches, @jsparkdev!
I just have a doubt regarding the order of script-src and style-src. Did you saw that by testing yourself?
Otherwise, all the other changes looks good to me!

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I was looking at the wrong place for the script-src/style-src order. So everything LGTM! Thanks! 🙌🏽

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the renaming etc. checks out with the code, thank you @jsparkdev !

I've asked about the one outstanding comment, and once that is resolved, this PR should be good to go!

@jsparkdev
Copy link
Member Author

jsparkdev commented Jun 7, 2025

@sarah11918 @ArmandPhilippot

Thank you all for your reviews.

I've noticed myself that enabling experimental.csp always brings up the style source first, but this appears to be a bug.

If I'm right about the bug, I've requested a bug fix in withastro/astro#13905 and will update the documentation once it's merged.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jsparkdev - amazing catches, as always!

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 9, 2025
@jsparkdev jsparkdev merged commit 4af3a32 into withastro:main Jun 9, 2025
10 checks passed
@jsparkdev jsparkdev deleted the fix-csp branch June 9, 2025 01:17
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants