Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: experimental serialized configuration #10791

Merged
merged 9 commits into from
Jan 29, 2025
Merged

feat: experimental serialized configuration #10791

merged 9 commits into from
Jan 29, 2025

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jan 24, 2025 •
edited by sarah11918
Loading

Description (required)

This PR creates a new page to explain the upcoming astro:config, highlighted in the roadmap PR withastro/roadmap#1106

For Astro version: 5.2.0. See astro PR #13084.

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 63e3425
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/679a7cd83027da00086ca8e4
😎 Deploy Preview https://deploy-preview-10791--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 24, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/serialized-configuration.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added this to the 5.2.0 milestone Jan 24, 2025
@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 24, 2025
@sarah11918
Copy link
Member

@ematipico Just checking on this one as it's still marked draft! I'll look over it tomorrow, but wanted to make sure it was close to ready!

@ematipico ematipico marked this pull request as ready for review January 28, 2025 07:01
@ematipico
Copy link
Member Author

That's ready for review

sarah11918
sarah11918 reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, especially of how to tackle each submodule! See what you think.

src/content/docs/en/reference/experimental-flags/serialized-configuration.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/experimental-flags/serialized-configuration.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/experimental-flags/serialized-configuration.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/experimental-flags/serialized-configuration.mdx Outdated Show resolved Hide resolved
@ematipico @sarah11918
Apply suggestions from code review
4b3e859 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Apply suggestions from code review
c1272b2 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico ematipico requested a review from sarah11918 January 29, 2025 17:07
sarah11918
sarah11918 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the example back in, and as long as it looks OK on the page, this is ready to go!

sarah11918
sarah11918 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adjusting the heading levels. Otherwise, we're good!

src/content/docs/en/reference/experimental-flags/serialized-configuration.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jan 29, 2025
@sarah11918 sarah11918 mentioned this pull request Jan 29, 2025
Merged
@sarah11918 sarah11918 changed the base branch from main to 5.2.0 January 29, 2025 19:11
@sarah11918 sarah11918 merged commit fb8e308 into 5.2.0 Jan 29, 2025
6 checks passed
@sarah11918 sarah11918 deleted the feat/experimental-serialized-config branch January 29, 2025 19:11
@ArmandPhilippot ArmandPhilippot mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @astrobot-houston @sarah11918