-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(fr): Update concepts/*
from #9240
#10135
i18n(fr): Update concepts/*
from #9240
#10135
Conversation
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]>
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
…rence) Signed-off-by: Thomas Bonnet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, one broken code snippet, and, in why-astro.mdx
, the link is up to date but we need to remove Lit
(l18). I can't add a suggestion there.
I also wonder if we should not agree on a single term to translate Island
. This is not new, but the page uses both îles
(islands) and îlots
(islets) as if they were synonyms. I think this could lead to confusion. But we can think about it and standardize it later.
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
I edit that!
I don't know about that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (when directive-reference
will be updated)!
I don't know about that...
Yeah, like I said... this was just me thinking while reviewing the page. It's not blocking here! No rush in any case, we have already plenty of pages to update. 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a nit, feel free to ignore or to reword like you want.
Edit: sorry for the double review... I forgot to add the comment once again. 😅
Co-authored-by: Armand Philippot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description (required)
i18n(fr): Update
concepts/*
from #9240 :Note
Err link at L106
islands
, waiting forreference/directives-reference
Related issues & labels (optional)