Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): Update concepts/* from #9240 #10135

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

thomasbnt
Copy link
Member

@thomasbnt thomasbnt commented Dec 3, 2024

Description (required)

i18n(fr): Update concepts/* from #9240 :

  • islands
  • why-astro

Note

Err link at L106 islands, waiting for reference/directives-reference

Related issues & labels (optional)

  • Closes #
  • Suggested label: i18n

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 46e0d34
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675c692d960b210008105692
😎 Deploy Preview https://deploy-preview-10135--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 3, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 3, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/concepts/islands.mdx Localization changed, will be marked as complete.
fr/concepts/why-astro.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, one broken code snippet, and, in why-astro.mdx, the link is up to date but we need to remove Lit (l18). I can't add a suggestion there.

I also wonder if we should not agree on a single term to translate Island. This is not new, but the page uses both îles (islands) and îlots (islets) as if they were synonyms. I think this could lead to confusion. But we can think about it and standardize it later.

src/content/docs/fr/concepts/islands.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/concepts/islands.mdx Outdated Show resolved Hide resolved
thomasbnt and others added 2 commits December 3, 2024 22:34
@thomasbnt
Copy link
Member Author

thomasbnt commented Dec 3, 2024

One nit, one broken code snippet, and, in why-astro.mdx, the link is up to date but we need to remove Lit (l18). I can't add a suggestion there.

I edit that!

I also wonder if we should not agree on a single term to translate Island. This is not new, but the page uses both îles (islands) and îlots (islets) as if they were synonyms. I think this could lead to confusion. But we can think about it and standardize it later.

I don't know about that...

Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (when directive-reference will be updated)!

I don't know about that...

Yeah, like I said... this was just me thinking while reviewing the page. It's not blocking here! No rush in any case, we have already plenty of pages to update. 😆

Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a nit, feel free to ignore or to reword like you want.

Edit: sorry for the double review... I forgot to add the comment once again. 😅

Co-authored-by: Armand Philippot <[email protected]>
Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasbnt thomasbnt merged commit 4e23378 into withastro:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants