Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Compiler error links invalid due to issue forms #328

Closed
boehs opened this issue Jan 8, 2022 · 5 comments · Fixed by withastro/astro#5855
Closed

🐛 BUG: Compiler error links invalid due to issue forms #328

boehs opened this issue Jan 8, 2022 · 5 comments · Fixed by withastro/astro#5855
Assignees

Comments

@boehs
Copy link
Contributor

boehs commented Jan 8, 2022

What version of astro are you using?

0.22.1

What package manager are you using?

pnpm

What operating system are you using?

linux

Describe the Bug

Compiler bugs instruct users to open an issue, but the prefill does not work because of issue forms. Also, they remove flexibility when opening an issue, such as below where a MRE is not needed

Link to Minimal Reproducible Example

n/a

@matthewp
Copy link
Contributor

matthewp commented Jan 8, 2022

What is the suggestion here?

@boehs
Copy link
Contributor Author

boehs commented Jan 8, 2022

What is the suggestion here?

  1. Update compiler errors to just spit out what to put into an issue instead of a link to open a new one
    Or
  2. Remove https://github.com/withastro/astro/blob/main/.github/ISSUE_TEMPLATE/---01-bug-report.yml and replace it with something like https://github.com/boehs/boehs/blob/master/.github/ISSUE_TEMPLATE/what.md, I expect this will allow the prefill to work, and it will give users more flexibility (such as removing the MRE section or adding new sections)
  3. Worst case: remove blank_issues_enabled: false from config.yml

@boehs
Copy link
Contributor Author

boehs commented Jan 8, 2022

@boehs boehs changed the title 🐛 BUG: Disable issue forms 🐛 BUG: Compiler error links invalid due to issue forms Jan 10, 2022
@jonathantneal
Copy link
Contributor

jonathantneal commented Jan 21, 2022

@boehs, would you be available to put these suggested fixes in a PR?

@boehs
Copy link
Contributor Author

boehs commented Jan 22, 2022

@boehs, would you be available to put these suggested fixes in a PR?

Yeah I'd be down to investigate shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants