-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Svelte 5 (experimental) #9098
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd80061
Support Svelte 5
bluwy 287f784
Update packages/integrations/svelte/src/index.ts
bluwy cf38b83
Fix server build
bluwy 98cc25c
Fix slot insertion with sibling elements
bluwy 7ec96ce
Tweak
bluwy 6e49574
Add changeset
bluwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@astrojs/svelte': patch | ||
--- | ||
|
||
Adds experimental support for Svelte 5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import { mount } from 'svelte'; | ||
|
||
export default (element) => { | ||
return async (Component, props, slotted) => { | ||
if (!element.hasAttribute('ssr')) return; | ||
|
||
let children = undefined; | ||
let $$slots = undefined; | ||
for (const [key, value] of Object.entries(slotted)) { | ||
if (key === 'default') { | ||
children = createSlotDefinition(key, value); | ||
} else { | ||
$$slots ??= {}; | ||
$$slots[key] = createSlotDefinition(key, value); | ||
} | ||
} | ||
|
||
const [, destroy] = mount(Component, { | ||
target: element, | ||
props: { | ||
...props, | ||
children, | ||
$$slots, | ||
}, | ||
}); | ||
|
||
element.addEventListener('astro:unmount', () => destroy(), { once: true }); | ||
}; | ||
}; | ||
|
||
function createSlotDefinition(key, children) { | ||
/** | ||
* @param {Comment} $$anchor A comment node for slots in Svelte 5 | ||
*/ | ||
return ($$anchor, _$$slotProps) => { | ||
const parent = $$anchor.parentNode; | ||
const el = document.createElement('div'); | ||
el.innerHTML = `<astro-slot${ | ||
key === 'default' ? '' : ` name="${key}"` | ||
}>${children}</astro-slot>`; | ||
parent.insertBefore(el.children[0], $$anchor); | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { render } from 'svelte/server'; | ||
|
||
function check(Component) { | ||
// Svelte 5 generated components always accept these two props | ||
const str = Component.toString(); | ||
return str.includes('$$payload') && str.includes('$$props'); | ||
} | ||
|
||
function needsHydration(metadata) { | ||
// Adjust how this is hydrated only when the version of Astro supports `astroStaticSlot` | ||
return metadata.astroStaticSlot ? !!metadata.hydrate : true; | ||
} | ||
|
||
async function renderToStaticMarkup(Component, props, slotted, metadata) { | ||
const tagName = needsHydration(metadata) ? 'astro-slot' : 'astro-static-slot'; | ||
|
||
let children = undefined; | ||
let $$slots = undefined; | ||
for (const [key, value] of Object.entries(slotted)) { | ||
if (key === 'default') { | ||
children = () => `<${tagName}>${value}</${tagName}>`; | ||
} else { | ||
$$slots ??= {}; | ||
$$slots[key] = () => `<${tagName} name="${key}">${value}</${tagName}>`; | ||
} | ||
} | ||
|
||
const { html } = render(Component, { | ||
props: { | ||
...props, | ||
children, | ||
$$slots, | ||
}, | ||
}); | ||
return { html }; | ||
} | ||
|
||
export default { | ||
check, | ||
renderToStaticMarkup, | ||
supportsAstroStaticSlot: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Hydration is removed in Svelte 5? Is there any way to use hydratable Svelte components (4.0 or earlier) in a Svelte 5 project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hydratable is enabled by default in Svelte 5. If you pass
hydratable: true
, it'll show a warning that you don't have to pass it now. I'll add a note here.