Deprecate drafts feature

.changeset/silent-bikes-crash.md

@@ -0,0 +1,6 @@
+---
+'@astrojs/rss': patch
+'astro': patch
+---
+
+Deprecate the drafts feature in favour of content collections. If you'd like to create draft pages that's visible in dev but not in prod, you can [migrate to content collections](https://docs.astro.build/en/guides/content-collections/#migrating-from-file-based-routing) and [manually filter out pages](https://docs.astro.build/en/guides/content-collections/#filtering-collection-queries) with the `draft: true` frontmatter property instead.

packages/astro-rss/src/index.ts

@@ -27,7 +27,10 @@ export type RSSOptions = {
 	stylesheet?: z.infer<typeof rssOptionsValidator>['stylesheet'];
 	/** Specify custom data in opening of file */
 	customData?: z.infer<typeof rssOptionsValidator>['customData'];
-	/** Whether to include drafts or not */
+	/**
+	 * Whether to include drafts or not
+	 * @deprecated since version 3.0. Use content collections instead.
+	 */
 	drafts?: z.infer<typeof rssOptionsValidator>['drafts'];
 	trailingSlash?: z.infer<typeof rssOptionsValidator>['trailingSlash'];
 };
@@ -45,7 +48,10 @@ export type RSSFeedItem = {
 	description?: z.infer<typeof rssSchema>['description'];
 	/** Append some other XML-valid data to this item */
 	customData?: z.infer<typeof rssSchema>['customData'];
-	/** Whether draft or not */
+	/**
+	 * Whether draft or not
+	 * @deprecated since version 3.0. Use content collections instead.
+	 */
 	draft?: z.infer<typeof rssSchema>['draft'];
 	/** Categories or tags related to the item */
 	categories?: z.infer<typeof rssSchema>['categories'];

packages/astro/src/@types/astro.ts

@@ -1017,6 +1017,7 @@ export interface AstroUserConfig {
 		 * @name markdown.drafts
 		 * @type {boolean}
 		 * @default `false`
+		 * @deprecated since version 3.0. Use content collections instead.
 		 * @description
 		 * Control whether Markdown draft pages should be included in the build.
 		 *
@@ -1460,6 +1461,10 @@ export interface ComponentInstance {
 	default: AstroComponentFactory;
 	css?: string[];
 	prerender?: boolean;
+	/**
+	 * Only used for logging if deprecated drafts feature is used
+	 */
+	frontmatter?: Record<string, any>;
 	getStaticPaths?: (options: GetStaticPathsOptions) => GetStaticPathsResult;
 }
 

packages/astro/src/core/build/generate.ts

@@ -37,7 +37,7 @@ import { runHookBuildGenerated } from '../../integrations/index.js';
 import { isServerLikeOutput } from '../../prerender/utils.js';
 import { BEFORE_HYDRATION_SCRIPT_ID, PAGE_SCRIPT_ID } from '../../vite-plugin-scripts/index.js';
 import { AstroError, AstroErrorData } from '../errors/index.js';
-import { debug, info } from '../logger/core.js';
+import { debug, info, warn } from '../logger/core.js';
 import { RedirectSinglePageBuiltModule, getRedirectLocationOrThrow } from '../redirects/index.js';
 import { isEndpointResult } from '../render/core.js';
 import { createEnvironment, createRenderContext, tryRenderRoute } from '../render/index.js';
@@ -249,6 +249,12 @@ async function generatePage(
 	const pageModule = await pageModulePromise();
 	if (shouldSkipDraft(pageModule, opts.settings)) {
 		info(opts.logging, null, `${magenta('⚠️')}  Skipping draft ${pageData.route.component}`);
+		// TODO: Remove in Astro 4.0
+		warn(
+			opts.logging,
+			'astro',
+			`The drafts feature is deprecated. You should migrate to content collections instead. See https://docs.astro.build/en/guides/content-collections/#filtering-collection-queries for more information.`
+		);
 		return;
 	}
 

packages/astro/src/core/render/core.ts

@@ -9,6 +9,7 @@ import type {
 import { renderPage as runtimeRenderPage } from '../../runtime/server/index.js';
 import { attachCookiesToResponse } from '../cookies/index.js';
 import { callEndpoint, createAPIContext, type EndpointCallResult } from '../endpoint/index.js';
+import { warn } from '../logger/core.js';
 import { callMiddleware } from '../middleware/callMiddleware.js';
 import { redirectRouteGenerate, redirectRouteStatus, routeIsRedirect } from '../redirects/index.js';
 import type { RenderContext } from './context.js';
@@ -58,6 +59,15 @@ export async function renderPage({ mod, renderContext, env, cookies }: RenderPag
 		locals: renderContext.locals ?? {},
 	});
 
+	// TODO: Remove in Astro 4.0
+	if (mod.frontmatter && typeof mod.frontmatter === 'object' && 'draft' in mod.frontmatter) {
+		warn(
+			env.logging,
+			'astro',
+			`The drafts feature is deprecated and used in ${renderContext.route.component}. You should migrate to content collections instead. See https://docs.astro.build/en/guides/content-collections/#filtering-collection-queries for more information.`
+		);
+	}
+
 	const response = await runtimeRenderPage(
 		result,
 		Component,