Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order-of-execution bug when generating pages #5822

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fix order-of-execution bug when generating pages #5822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754a3d5
fix: bundle all pages into a single chunk
natemoo-re Jan 10, 2023
078ad7c
chore: add changeset
natemoo-re Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-beds-smile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fix edge case with bundle generation by emitting a single chunk for pages
4 changes: 2 additions & 2 deletions packages/astro/src/core/build/vite-plugin-prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export function vitePluginPrerender(
if (api.getModuleInfo(id)?.meta.astro?.pageOptions?.prerender) {
return `prerender`;
}
// pages should go in their own chunks/pages/* directory
return `pages${pageInfo.route.route.replace(/\/$/, '/index')}`;
// dynamic pages should all go in their own chunk in the pages/* directory
return `pages/all`;
}
};
},
Expand Down