Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement redesign of portfolio example #5765

Merged
merged 116 commits into from
Jan 13, 2023
Merged

Implement redesign of portfolio example #5765

merged 116 commits into from
Jan 13, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 5, 2023

Changes

  • Replace our current portfolio example with a new design by @doodlemarks

This is a more fully featured example than some of our more basic starters, so closer to a real “theme”. I think that was the general idea with this, so hopefully that’s OK. The starter does not include any dependencies apart from astro but does add some custom components including an <Icon> that contains the icons Mark suggested from the Phosphor icon set.

Try it on StackBlitz →

Questions

  • The original design used Public Sans for body text. I’ve stuck with this for now, but is there an argument for dropping Public in favour of a system font? Public is a fairly similar sans to the default sans-serif bundled on most devices and we’re already loading Rubik as a custom font for headings.

  • Should this be our first full example that uses Content Collections? This example already includes a type for frontmatter and suffers from the style bleed issue when globbing projects for the homepage/work index, so could make sense to set those up a schema?

  • There is some complexity getting all the background gradient images to work nicely, including multiple resolutions per background and some custom lazy loading for below the fold backgrounds. Is this too much complexity for a theme like this? Maybe there’s some alternative design approach that is lighter and we use background images just for the page headers.

To-do

  • Some astro check errors in CI — will clean those up

Light mode

Screen Shot 2023-01-05 at 13 20 26

Dark mode

Screen Shot 2023-01-05 at 13 20 17

Testing

  • Lots of manual testing during development across browsers & devices — more eyes always appreciated.
  • All pages pass accessibility audits.

Docs

We don’t generally document much for these, so guess we stick to that pattern? The screenshot on astro.new will need updating.

@delucis delucis self-assigned this Jan 6, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking amazing! Had a few small copy comments, recognizing this is all placeholder content.

I also think using Content Collections would be ideal here since we're excited about it and people will be looking for examples of it 👍🏻

examples/portfolio/src/components/Icon.astro Outdated Show resolved Hide resolved
examples/portfolio/src/components/Skills.astro Outdated Show resolved Hide resolved
examples/portfolio/src/pages/about.astro Outdated Show resolved Hide resolved
examples/portfolio/src/pages/work.astro Outdated Show resolved Hide resolved
examples/portfolio/src/styles/global.css Outdated Show resolved Hide resolved
@tony-sull
Copy link
Contributor

This is looking great! Followed up with Chris offline to dig into the background images and perf testing, notes below

  • looked like the SVG used for background noise was still going to be a perf issue, moving to a tiled PNG
  • sticking with Google Fonts to avoid extra NPM deps, lighthouse scores look good enough for the trade-off in simplicity for a starter
  • content collections API should clean up style bleed issues

@delucis delucis merged commit ca22a81 into main Jan 13, 2023
@delucis delucis deleted the chris/portfolio-redesign branch January 13, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants