Skip to content

Fix tsc errors in shipped Font.astro and Picture.astro when using @astrojs/ts-content-mapper #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Princesseuh merged 3 commits into from
Oct 5, 2026
Merged

Fix tsc errors in shipped Font.astro and Picture.astro when using @astrojs/ts-content-mapper #18220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad6d07d
fix(astro): make Picture and Font components type-check under ts-cont…
factory[bot] Oct 4, 2026
cbbe2e1
fix(astro): ignore unresolved virtual font module
Princesseuh Oct 5, 2026
3b220f3
Apply suggestion from @Princesseuh
Princesseuh Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/frank-papayas-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes type errors reported in Astro's built-in `<Picture />` and `<Font />` components when type-checking a project with `tsc` and `@astrojs/ts-content-mapper`
1 change: 1 addition & 0 deletions packages/astro/components/Font.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
// @ts-ignore-error This virtual module is resolved by Astro at runtime and declared in dev-only.d.ts.
Comment thread
Princesseuh marked this conversation as resolved.
Resolved
import { componentDataByCssVariable } from 'virtual:astro:assets/fonts/internal';
import { filterPreloads } from '../dist/assets/fonts/core/filter-preloads.js';
import { AstroError, AstroErrorData } from '../dist/core/errors/index.js';
Expand Down
4 changes: 2 additions & 2 deletions packages/astro/components/Picture.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ const originalSrc = await resolveSrc(props.src);
// When inferSize is set for a remote image, resolve dimensions once and thread them through
// to all getImage() calls. This avoids multiple redundant HTTP requests to the same URL,
// which can trigger rate-limiting (HTTP 429) on servers like Wikimedia.
if (props.inferSize && isRemoteImage(originalSrc)) {
if ('inferSize' in props && props.inferSize && isRemoteImage(originalSrc)) {
const remoteSize = await inferRemoteSize(originalSrc);
delete props.inferSize;
delete (props as { inferSize?: boolean }).inferSize;
props.width ??= remoteSize.width;
props.height ??= remoteSize.height;
}
Expand Down
Loading