Skip to content

Fix issue with dynamic routes in complex projects using workerd #16720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomas-callahan-collibra wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −2
Open

Fix issue with dynamic routes in complex projects using workerd #16720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7bdddf
update Node detection
thomas-callahan-collibra May 12, 2026
b5f6c3c
add changeset
thomas-callahan-collibra May 12, 2026
1a86c67
add missing export
thomas-callahan-collibra May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-jeans-brake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Fix an issue where dynamic routes in complex projects return the string [object Object] instead of the expected content
5 changes: 3 additions & 2 deletions packages/astro/src/runtime/server/render/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,9 @@ export interface RendererFlusher {
flush(): void | Promise<void>;
}

export const isNode =
typeof process !== 'undefined' && Object.prototype.toString.call(process) === '[object process]';
export const isNode = typeof process !== "undefined"
&& Object.prototype.toString.call(process) === "[object process]"
&& !(typeof navigator !== "undefined" && navigator.userAgent === "Cloudflare-Workers");
// @ts-expect-error: Deno is not part of the types.
export const isDeno = typeof Deno !== 'undefined';

Expand Down
Loading