-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update pnpm to v11 #16716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pnpm to v11 #16716
Changes from all commits
35c358c
d6f7336
84d5ace
9a9589d
a80e79a
431219e
36ca64d
2ee0bc3
f609928
fe0c779
9050066
463b3f6
0f15789
99d5a9f
d9c66d2
9a8925f
64b0dd7
555d95a
536a8ae
d89b4a5
0c783bd
c53b7b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@astrojs/netlify': patch | ||
| --- | ||
|
|
||
| Updates internal dependencies |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@astrojs/ts-plugin': patch | ||
| 'astro-vscode': patch | ||
| --- | ||
|
|
||
| Drops support for versions of VS Code below 1.101.0 [May 2025] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,8 +11,6 @@ | |
| "astro": "workspace:*" | ||
| }, | ||
| "dependencies": { | ||
| "@webcomponents/template-shadowroot": "^0.2.1", | ||
| "lit": "^3.3.2", | ||
|
Comment on lines
-14
to
-15
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These packages used to be used in this fixture but are no longer needed now we don’t have the Lit integration. Removing them allowed me to clean up some pnpm config.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. haha, i can't believe we still had this. |
||
| "preact": "^10.29.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/cloudflare": "workspace:*", | ||
| "@astrojs/solid-js": "^5.1.3", | ||
| "@astrojs/solid-js": "workspace:*", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fixture and a few others were not using |
||
| "astro": "workspace:*", | ||
| "solid-js": "^1.9.11" | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hack no longer works: it appears pnpm 11 will run an install if it detects that packages are not installed correctly. This means that this reset caused the subsequent
pnpm run buildto rerun an install, which fails due to frozen lockfile requirements in CI. There’s no way to pass--no-frozen-lockfilein this scenario though.I tested this in a small dummy project where I manually added a dep to
package.jsonand tried running a script. pnpm 11 immediately went to install the dep before running the script.