refactor(db): migrate tests to typescript

packages/db/package.json

@@ -68,8 +68,9 @@
     "build:ci": "astro-scripts build \"src/**/*.ts\"",
     "dev": "astro-scripts dev \"src/**/*.ts\"",
     "test": "pnpm run test:integration && pnpm run test:types",
-    "test:integration": "astro-scripts test \"test/**/*.test.js\"",
-    "test:types": "tsc --project test/types/tsconfig.json"
+    "test:integration": "astro-scripts test \"test/**/*.test.ts\"",
+    "test:types": "tsc --project test/types/tsconfig.json",
+    "typecheck:tests": "tsc --build tsconfig.test.json"
   },
   "dependencies": {
     "@clack/prompts": "^1.0.1",

packages/db/test/basics.test.js → packages/db/test/basics.test.ts

@@ -2,12 +2,12 @@ import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
 import testAdapter from '../../astro/test/test-adapter.js';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 import { resolveDbAppToken } from '../dist/core/utils.js';
-import { clearEnvironment, setupRemoteDb } from './test-utils.js';
+import { clearEnvironment, type RemoteDbServer, setupRemoteDb } from './test-utils.ts';
 
 describe('astro:db', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/basics/', import.meta.url),
@@ -17,7 +17,7 @@ describe('astro:db', () => {
 	});
 
 	describe('development', () => {
-		let devServer;
+		let devServer: DevServer;
 
 		before(async () => {
 			clearEnvironment();
@@ -96,8 +96,8 @@ describe('astro:db', () => {
 	});
 
 	describe('development --remote', () => {
-		let devServer;
-		let remoteDbServer;
+		let devServer: DevServer;
+		let remoteDbServer: RemoteDbServer;
 
 		before(async () => {
 			clearEnvironment();
@@ -178,7 +178,7 @@ describe('astro:db', () => {
 	});
 
 	describe('build --remote', () => {
-		let remoteDbServer;
+		let remoteDbServer: RemoteDbServer;
 
 		before(async () => {
 			clearEnvironment();
@@ -219,13 +219,11 @@ describe('astro:db', () => {
 
 	describe('Precedence for --db-app-token and ASTRO_DB_APP_TOKEN handled correctly', () => {
 		it('prefers --db-app-token over `ASTRO_DB_APP_TOKEN`', () => {
-			const flags = /** @type {any} */ ({ _: [], dbAppToken: 'from-flag' });
-			assert.equal(resolveDbAppToken(flags, 'from-env'), 'from-flag');
+			assert.equal(resolveDbAppToken({ _: [], dbAppToken: 'from-flag' }, 'from-env'), 'from-flag');
 		});
 
 		it('falls back to ASTRO_DB_APP_TOKEN if no flags set', () => {
-			const flags = /** @type {any} */ ({ _: [] });
-			assert.equal(resolveDbAppToken(flags, 'from-env'), 'from-env');
+			assert.equal(resolveDbAppToken({ _: [] }, 'from-env'), 'from-env');
 		});
 	});
 });

packages/db/test/db-in-src.test.js → packages/db/test/db-in-src.test.ts

@@ -2,10 +2,10 @@ import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
 import testAdapter from '../../astro/test/test-adapter.js';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 
 describe('astro:db', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/db-in-src/', import.meta.url),
@@ -16,7 +16,7 @@ describe('astro:db', () => {
 	});
 
 	describe('development: db/ folder inside srcDir', () => {
-		let devServer;
+		let devServer: DevServer;
 
 		before(async () => {
 			devServer = await fixture.startDevServer();

packages/db/test/error-handling.test.js → packages/db/test/error-handling.test.ts

@@ -1,13 +1,13 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 import { cli } from '../dist/core/cli/index.js';
-import { setupRemoteDb } from './test-utils.js';
+import { type RemoteDbServer, setupRemoteDb } from './test-utils.ts';
 
 const foreignKeyConstraintError = 'LibsqlError: SQLITE_CONSTRAINT: FOREIGN KEY constraint failed';
 
 describe('astro:db - error handling', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/error-handling/', import.meta.url),
@@ -17,20 +17,19 @@ describe('astro:db - error handling', () => {
 	it('Errors on invalid --db-app-token input', async () => {
 		const originalExit = process.exit;
 		const originalError = console.error;
-		/** @type {string[]} */
-		const errorMessages = [];
-		console.error = (...args) => {
+		const errorMessages: string[] = [];
+		console.error = (...args: unknown[]) => {
 			errorMessages.push(args.map(String).join(' '));
 		};
-		process.exit = (code) => {
+		process.exit = ((code?: number) => {
 			throw new Error(`EXIT_${code}`);
-		};
+		}) as typeof process.exit;
 
 		try {
 			await cli({
 				config: fixture.config,
 				flags: {
-					_: [undefined, 'astro', 'db', 'verify'],
+					_: ['', 'astro', 'db', 'verify'],
 					dbAppToken: true,
 				},
 			});
@@ -48,7 +47,7 @@ describe('astro:db - error handling', () => {
 	});
 
 	describe('development', () => {
-		let devServer;
+		let devServer: DevServer;
 
 		before(async () => {
 			devServer = await fixture.startDevServer();
@@ -68,7 +67,7 @@ describe('astro:db - error handling', () => {
 	});
 
 	describe('build --remote', () => {
-		let remoteDbServer;
+		let remoteDbServer: RemoteDbServer;
 
 		before(async () => {
 			remoteDbServer = await setupRemoteDb(fixture.config);

packages/db/test/integration-only.test.js → packages/db/test/integration-only.test.ts

@@ -1,18 +1,18 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 
 describe('astro:db with only integrations, no user db config', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/integration-only/', import.meta.url),
 		});
 	});
 
 	describe('development', () => {
-		let devServer;
+		let devServer: DevServer;
 		before(async () => {
 			devServer = await fixture.startDevServer();
 		});

packages/db/test/integrations.test.js → packages/db/test/integrations.test.ts

@@ -1,18 +1,18 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 
 describe('astro:db with integrations', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/integrations/', import.meta.url),
 		});
 	});
 
 	describe('development', () => {
-		let devServer;
+		let devServer: DevServer;
 
 		before(async () => {
 			devServer = await fixture.startDevServer();

packages/db/test/libsql-remote.test.js → packages/db/test/libsql-remote.test.ts

@@ -4,20 +4,20 @@ import { relative } from 'node:path';
 import { after, before, describe, it } from 'node:test';
 import { fileURLToPath } from 'node:url';
 import testAdapter from '../../astro/test/test-adapter.js';
-import { loadFixture } from '../../astro/test/test-utils.js';
-import { clearEnvironment, initializeRemoteDb } from './test-utils.js';
+import { type Fixture, loadFixture } from '../../astro/test/test-utils.js';
+import { clearEnvironment, initializeRemoteDb } from './test-utils.ts';
 
 describe('astro:db local database', () => {
 	describe('build --remote with local libSQL file (absolute path)', () => {
-		let fixture;
+		let fixture: Fixture;
 		before(async () => {
 			clearEnvironment();
 
 			const absoluteFileUrl = new URL('./fixtures/libsql-remote/temp/absolute.db', import.meta.url);
 			// Remove the file if it exists to avoid conflict between test runs
 			await rm(absoluteFileUrl, { force: true });
 
-			process.env.ASTRO_INTERNAL_TEST_REMOTE = true;
+			process.env.ASTRO_INTERNAL_TEST_REMOTE = 'true';
 			process.env.ASTRO_DB_REMOTE_URL = absoluteFileUrl.toString();
 
 			const root = new URL('./fixtures/libsql-remote/', import.meta.url);
@@ -46,7 +46,7 @@ describe('astro:db local database', () => {
 	});
 
 	describe('build --remote with local libSQL file (relative path)', () => {
-		let fixture;
+		let fixture: Fixture;
 		before(async () => {
 			clearEnvironment();
 
@@ -56,7 +56,7 @@ describe('astro:db local database', () => {
 			// Remove the file if it exists to avoid conflict between test runs
 			await rm(prodDbPath, { force: true });
 
-			process.env.ASTRO_INTERNAL_TEST_REMOTE = true;
+			process.env.ASTRO_INTERNAL_TEST_REMOTE = 'true';
 			process.env.ASTRO_DB_REMOTE_URL = `file:${prodDbPath}`;
 
 			const root = new URL('./fixtures/libsql-remote/', import.meta.url);

packages/db/test/local-prod.test.js → packages/db/test/local-prod.test.ts

@@ -3,11 +3,11 @@ import { relative } from 'node:path';
 import { after, before, describe, it } from 'node:test';
 import { fileURLToPath } from 'node:url';
 import testAdapter from '../../astro/test/test-adapter.js';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 
 describe('astro:db local database', () => {
 	describe('build (not remote) with DATABASE_FILE env (file URL)', () => {
-		let fixture;
+		let fixture: Fixture;
 		const prodDbPath = new URL('./fixtures/basics/dist/astro.db', import.meta.url).toString();
 		before(async () => {
 			process.env.ASTRO_DATABASE_FILE = prodDbPath;
@@ -34,7 +34,7 @@ describe('astro:db local database', () => {
 	});
 
 	describe('build (not remote) with DATABASE_FILE env (relative file path)', () => {
-		let fixture;
+		let fixture: Fixture;
 		const absoluteFileUrl = new URL('./fixtures/basics/dist/astro.db', import.meta.url);
 		const prodDbPath = relative(process.cwd(), fileURLToPath(absoluteFileUrl));
 
@@ -72,7 +72,7 @@ describe('astro:db local database', () => {
 				output: 'server',
 				adapter: testAdapter(),
 			});
-			let buildError = null;
+			let buildError: unknown = null;
 			try {
 				await fixture.build();
 			} catch (err) {
@@ -92,7 +92,7 @@ describe('astro:db local database', () => {
 			});
 
 			delete process.env.ASTRO_DATABASE_FILE;
-			let buildError = null;
+			let buildError: unknown = null;
 			try {
 				await fixture2.build();
 			} catch (err) {

packages/db/test/no-seed.test.js → packages/db/test/no-seed.test.ts

@@ -1,18 +1,18 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
-import { loadFixture } from '../../astro/test/test-utils.js';
+import { type DevServer, type Fixture, loadFixture } from '../../astro/test/test-utils.js';
 
 describe('astro:db with no seed file', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/no-seed/', import.meta.url),
 		});
 	});
 
 	describe('development', () => {
-		let devServer;
+		let devServer: DevServer;
 		before(async () => {
 			devServer = await fixture.startDevServer();
 		});

packages/db/test/ssr-no-apptoken.test.js → packages/db/test/ssr-no-apptoken.test.ts

@@ -1,12 +1,12 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import testAdapter from '../../astro/test/test-adapter.js';
-import { loadFixture } from '../../astro/test/test-utils.js';
-import { setupRemoteDb } from './test-utils.js';
+import { type Fixture, loadFixture } from '../../astro/test/test-utils.js';
+import { type RemoteDbServer, setupRemoteDb } from './test-utils.ts';
 
 describe('missing app token', () => {
-	let fixture;
-	let remoteDbServer;
+	let fixture: Fixture;
+	let remoteDbServer: RemoteDbServer;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/no-apptoken/', import.meta.url),

packages/db/test/static-remote.test.js → packages/db/test/static-remote.test.ts

@@ -1,11 +1,11 @@
 import assert from 'node:assert/strict';
 import { after, before, describe, it } from 'node:test';
 import { load as cheerioLoad } from 'cheerio';
-import { loadFixture } from '../../astro/test/test-utils.js';
-import { clearEnvironment, setupRemoteDb } from './test-utils.js';
+import { type Fixture, loadFixture } from '../../astro/test/test-utils.js';
+import { clearEnvironment, type RemoteDbServer, setupRemoteDb } from './test-utils.ts';
 
 describe('astro:db', () => {
-	let fixture;
+	let fixture: Fixture;
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/static-remote/', import.meta.url),
@@ -14,7 +14,7 @@ describe('astro:db', () => {
 	});
 
 	describe('static build --remote', () => {
-		let remoteDbServer;
+		let remoteDbServer: RemoteDbServer;
 
 		before(async () => {
 			remoteDbServer = await setupRemoteDb(fixture.config);
@@ -41,7 +41,7 @@ describe('astro:db', () => {
 	});
 
 	describe('static build --remote with custom LibSQL', () => {
-		let remoteDbServer;
+		let remoteDbServer: RemoteDbServer | undefined;
 
 		before(async () => {
 			clearEnvironment();