Skip to content

refactor(astro): migrate error tests to typescript #16377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 3 commits into from
Apr 17, 2026
Merged

refactor(astro): migrate error tests to typescript #16377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f2587
refactor(astro): migrate error tests to typescript
ocavue Apr 17, 2026
42c51f5
chore: trigger ci
ocavue Apr 17, 2026
64ea459
chore: trigger ci
ocavue Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/astro/test/error-bad-js.test.js → packages/astro/test/error-bad-js.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import assert from 'node:assert/strict';
import { after, before, describe, it } from 'node:test';
import testAdapter from './test-adapter.js';
import { loadFixture } from './test-utils.js';
import { loadFixture, type Fixture, type DevServer } from './test-utils.js';

describe('Errors in JavaScript', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
let fixture: Fixture;

before(async () => {
fixture = await loadFixture({
Expand All @@ -19,8 +18,7 @@ describe('Errors in JavaScript', () => {
});

describe('dev', () => {
/** @type {import('./test-utils').DevServer} */
let devServer;
let devServer: DevServer;

before(async () => {
devServer = await fixture.startDevServer();
Expand All @@ -45,7 +43,7 @@ describe('Errors in JavaScript', () => {

describe('build', () => {
before(async () => {
await fixture.build();
await fixture.build({});
});

it('in nested components, does not crash server', async () => {
Expand Down
10 changes: 5 additions & 5 deletions ...s/astro/test/error-build-location.test.js → ...s/astro/test/error-build-location.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import assert from 'node:assert/strict';
import { describe, it } from 'node:test';
import { loadFixture } from './test-utils.js';
import { loadFixture, type Fixture } from './test-utils.js';

describe('Errors information in build', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
let fixture: Fixture;

it('includes the file where the error happened', async () => {
fixture = await loadFixture({
root: './fixtures/error-build-location',
});

let errorContent;
let errorContent: any;
try {
await fixture.build();
await fixture.build({});
} catch (e) {
errorContent = e;
}

assert.equal(errorContent.id, 'src/pages/index.astro');
assert.equal(errorContent.message, `I'm happening in build!`);
});
});
8 changes: 2 additions & 6 deletions packages/astro/test/error-map.test.js → packages/astro/test/error-map.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,11 @@ describe('Content Collections - error map', () => {
});
});

/**
* @param {z.ZodError} error
* @returns string[]
*/
function messages(error) {
function messages(error: z.ZodError): string[] {
return error.issues.map((e) => e.message);
}

function getParseError(schema, entry, parseOpts = { error: errorMap }) {
function getParseError(schema: z.Schema, entry: unknown, parseOpts = { error: errorMap }) {
const res = schema.safeParse(entry, parseOpts);
assert.equal(res.success, false, 'Schema should raise error');
return res.error;
Expand Down
8 changes: 3 additions & 5 deletions packages/astro/test/error-non-error.test.js → packages/astro/test/error-non-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import assert from 'node:assert/strict';
import { after, before, describe, it } from 'node:test';
import { loadFixture } from './test-utils.js';
import { loadFixture, type Fixture, type DevServer } from './test-utils.js';

describe('Can handle errors that are not instanceof Error', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
let fixture: Fixture;

/** @type {import('./test-utils').DevServer} */
let devServer;
let devServer: DevServer;

before(async () => {
fixture = await loadFixture({
Expand Down
Loading