Skip to content

chore: add rule for detecting incorrect imports #16343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Apr 16, 2026
Merged

chore: add rule for detecting incorrect imports #16343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions biome.jsonc
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

If that ain't a nested JSON...

Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,26 @@
}
}
}
},
{
"includes": ["**/astro/test/**"],
"linter": {
"rules": {
"style": {
"noRestrictedImports": {
"level": "error",
"options": {
"patterns": [
{
"group": ["**/src/**"],
"message": "The test should not import the source code. Import the code from the dist/ folder instead."
}
]
}
}
}
}
}
}
]
}
6 changes: 3 additions & 3 deletions packages/astro/test/types/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { describe, it } from 'node:test';
import { expectTypeOf } from 'expect-type';
import type * as z from 'zod/v4';
import { type FontProviderSchema, FontFamilySchema } from '../../src/assets/fonts/config.js';
import type { FontProvider, FontFamily } from '../../src/assets/fonts/types.js';
import type { CacheSchema, RouteRulesSchema } from '../../src/core/cache/config.js';
import { type FontProviderSchema, FontFamilySchema } from '../../dist/assets/fonts/config.js';
import type { FontProvider, FontFamily } from '../../dist/assets/fonts/types.js';
import type { CacheSchema, RouteRulesSchema } from '../../dist/core/cache/config.js';
import type { CacheProviderConfig, RouteRules } from '../../dist/core/cache/types.js';
import type { SessionDriverConfigSchema } from '../../dist/core/session/config.js';
import type { SessionDriverConfig } from '../../dist/core/session/types.js';
Expand Down
Loading