-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
chore: adapt code to upstream deprecation #16192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
00fe32c
chore: adapt code to upstream deprecation
alexanderniebuhr e625092
fix remove ununsed import
alexanderniebuhr 5a27648
Apply suggestion from @alexanderniebuhr
alexanderniebuhr b529990
Apply suggestion from @alexanderniebuhr
alexanderniebuhr 7247a45
Apply suggestion from @alexanderniebuhr
alexanderniebuhr 25613de
Apply suggestion from @alexanderniebuhr
alexanderniebuhr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@astrojs/cloudflare': patch | ||
| --- | ||
|
|
||
| Removes unused re-export from info helper function | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| 'astro': patch | ||
| --- | ||
|
|
||
| Updates `astro add cloudflare` to alway use the todays day as `compatibility_date` in the wrangler config, adapting to deprecation due to [upstream changes](https://github.com/cloudflare/workers-sdk/pull/13051) | ||
|
alexanderniebuhr marked this conversation as resolved.
Outdated
|
||
|
|
||
| Previously, when generating a compatibility date for new projects, the date was resolved by loading the locally packages. This approach was unreliable in some package manager environments. The logic now simply uses today's date instead, which is always correct and works reliably across all environments, this should always reliably work since now workerd supports dates up to 7 days in the future. | ||
|
alexanderniebuhr marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.