Skip to content

fix(cloudflare): ensure HMR works when prerenderEnvironment is set to 'node' #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 5 commits into from
Apr 1, 2026
Merged

fix(cloudflare): ensure HMR works when prerenderEnvironment is set to 'node' #16162

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f48ea1
fix(cloudflare): ensure HMR works when `prerenderEnvironment` is set …
rururux Mar 31, 2026
d24838a
Merge branch 'main' into cf-node-prerender-hmr
matthewp Mar 31, 2026
b7478fb
Merge branch 'main' into cf-node-prerender-hmr
rururux Mar 31, 2026
61eb3b8
Merge branch 'main' into cf-node-prerender-hmr
rururux Apr 1, 2026
8442198
Merge branch 'main' into cf-node-prerender-hmr
matthewp Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-balloons-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes an issue where HMR would not trigger when modifying files while using @astrojs/cloudflare with prerenderEnvironment: 'node' enabled.
34 changes: 34 additions & 0 deletions packages/astro/e2e/cloudflare-node-prerender-hmr.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { expect } from '@playwright/test';
import { testFactory } from './test-utils.js';

const test = testFactory(import.meta.url, {
root: './fixtures/cloudflare-node-prerender-hmr/',
devToolbar: {
enabled: false,
},
});

let devServer;

test.beforeAll(async ({ astro }) => {
devServer = await astro.startDevServer();
});

test.afterAll(async () => {
await devServer.stop();
});

test.describe('Astro page', () => {
test('refresh with HMR', async ({ page, astro }) => {
await page.goto(astro.resolveUrl('/'));

const h = page.locator('h1');
await expect(h, 'original text set').toHaveText('Original content');

await astro.editFile('./src/pages/index.astro', (original) =>
original.replaceAll('Original', 'Updated'),
);

await expect(h, 'text changed').toHaveText('Updated content');
});
});
9 changes: 9 additions & 0 deletions packages/astro/e2e/fixtures/cloudflare-node-prerender-hmr/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// @ts-check
import cloudflare from '@astrojs/cloudflare';
import { defineConfig } from 'astro/config';

export default defineConfig({
adapter: cloudflare({
prerenderEnvironment: 'node',
}),
});
13 changes: 13 additions & 0 deletions packages/astro/e2e/fixtures/cloudflare-node-prerender-hmr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "@test/astro-cloudflare-node-prerender-mdx",
"version": "0.0.0",
"private": true,
"scripts": {
"dev": "astro dev",
"build": "astro build"
},
"dependencies": {
"@astrojs/cloudflare": "workspace:*",
"astro": "workspace:*"
}
}
6 changes: 6 additions & 0 deletions packages/astro/e2e/fixtures/cloudflare-node-prerender-hmr/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---
<html>
<head><title>Original content</title></head>
<body><h1>Original content</h1></body>
</html>
4 changes: 2 additions & 2 deletions packages/astro/src/vite-plugin-hmr-reload/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { EnvironmentModuleNode, Plugin } from 'vite';
import { ASTRO_VITE_ENVIRONMENT_NAMES } from '../core/constants.js';
import { VIRTUAL_PAGE_RESOLVED_MODULE_ID } from '../vite-plugin-pages/const.js';
import { getDevCssModuleNameFromPageVirtualModuleName } from '../vite-plugin-css/util.js';
import { isAstroServerEnvironment } from '../environments.js';

/**
* The very last Vite plugin to reload the browser if any SSR-only module are updated
Expand All @@ -15,7 +15,7 @@ export default function hmrReload(): Plugin {
hotUpdate: {
order: 'post',
handler({ modules, server, timestamp }) {
if (this.environment.name !== ASTRO_VITE_ENVIRONMENT_NAMES.ssr) return;
if (!isAstroServerEnvironment(this.environment)) return;

let hasSsrOnlyModules = false;

Expand Down
9 changes: 9 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading