Skip to content

fix(fonts): invalid dev url with oblique style and angles #16075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florian-lefebvre merged 1 commit into from
Mar 25, 2026
Merged

fix(fonts): invalid dev url with oblique style and angles #16075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tired-worlds-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a case where invalid URLs would be generated in development when using font families with an oblique `style` and angles
6 changes: 5 additions & 1 deletion packages/astro/src/assets/fonts/infra/dev-font-file-id-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export class DevFontFileIdGenerator implements FontFileIdGenerator {
return weight?.replace(/\s+/g, '-');
}

#formatStyle(style: unifont.FontFaceData['style']): string | undefined {
return style?.replace(/\s+/g, '-')
}

generate({
cssVariable,
originalUrl,
Expand All @@ -41,7 +45,7 @@ export class DevFontFileIdGenerator implements FontFileIdGenerator {
return [
cssVariable.slice(2),
this.#formatWeight(font.weight),
font.style,
this.#formatStyle(font.style),
font.meta?.subset,
`${this.#hasher.hashString(this.#contentResolver.resolve(originalUrl))}.${type}`,
]
Expand Down
9 changes: 9 additions & 0 deletions packages/astro/test/units/assets/fonts/infra.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,15 @@ describe('fonts infra', () => {
}),
'foo-200-700-italic-cyrillic-whatever.woff2',
);
assert.equal(
resolver.generate({
cssVariable: '--foo',
font: { weight: '500', style: 'oblique 0deg 15deg', meta: { subset: 'latin' }, src: [] },
originalUrl: 'whatever',
type: 'woff2',
}),
'foo-500-oblique-0deg-15deg-latin-whatever.woff2',
);
});

describe('UnifontFontResolver', () => {
Expand Down
Loading