fix(session): regenerate new session IDs from cookies#15752
Merged
Conversation
When a session ID is supplied via cookie but has no corresponding server-side data, generate a new ID instead of accepting the unknown one. This prevents session fixation where an attacker pre-sets a known session ID in the victim's cookie.
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Mar 4, 2026
ascorbic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#ensureSessionID()to track whether the session ID originated from a client cookie vs. being freshly generated#sessionIDFromCookieflag that is checked in#ensureData()and reset inregenerate()Testing
Added tests
Docs
No user-facing changes