refactor(cli): info

.changeset/fancy-cases-act.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Improves `astro info`

packages/astro/src/cli/flags.ts

@@ -6,6 +6,7 @@ import type { AstroInlineConfig } from '../types/public/config.js';
 // Alias for now, but allows easier migration to node's `parseArgs` in the future.
 export type Flags = Arguments;
 
+/** @deprecated Use AstroConfigResolver instead */
 export function flagsToAstroInlineConfig(flags: Flags): AstroInlineConfig {
 	return {
 		// Inline-only configs

packages/astro/src/cli/index.ts

@@ -96,9 +96,65 @@ async function runCommand(cmd: string, flags: yargs.Arguments) {
 			return;
 		}
 		case 'info': {
-			const { printInfo } = await import('./info/index.js');
-			await printInfo({ flags });
-			return;
+			const [
+				{ createProcessOperatingSystemProvider },
+				{ createCliAstroConfigResolver },
+				{ createProcessPackageManagerUserAgentProvider },
+				{ createProcessNodeVersionProvider },
+				{ createCliDebugInfoProvider },
+				{ createTinyexecCommandExecutor },
+				{ getPackageManager },
+				{ createStyledDebugInfoFormatter },
+				{ createPromptsPrompt },
+				{ createCliClipboard },
+				{ createPassthroughTextStyler },
+				{ infoCommand },
+			] = await Promise.all([
+				import('./infra/process-operating-system-provider.js'),
+				import('./info/infra/cli-astro-config-resolver.js'),
+				import('./info/infra/process-package-manager-user-agent-provider.js'),
+				import('./info/infra/process-node-version-provider.js'),
+				import('./info/infra/cli-debug-info-provider.js'),
+				import('./infra/tinyexec-command-executor.js'),
+				import('./info/core/get-package-manager.js'),
+				import('./info/infra/styled-debug-info-formatter.js'),
+				import('./info/infra/prompts-prompt.js'),
+				import('./info/infra/cli-clipboard.js'),
+				import('./infra/passthrough-text-styler.js'),
+				import('./info/core/info.js'),
+			]);
+			const operatingSystemProvider = createProcessOperatingSystemProvider();
+			const astroConfigResolver = createCliAstroConfigResolver({ flags });
+			const commandExecutor = createTinyexecCommandExecutor();
+			const packageManagerUserAgentProvider = createProcessPackageManagerUserAgentProvider();
+			const nodeVersionProvider = createProcessNodeVersionProvider();
+			const debugInfoProvider = createCliDebugInfoProvider({
+				config: await astroConfigResolver.resolve(),
+				astroVersionProvider,
+				operatingSystemProvider,
+				packageManager: await getPackageManager({
+					packageManagerUserAgentProvider,
+					commandExecutor,
+				}),
+				nodeVersionProvider,
+			});
+			const prompt = createPromptsPrompt({ force: flags.copy });
+			const clipboard = createCliClipboard({
+				commandExecutor,
+				logger,
+				operatingSystemProvider,
+				prompt,
+			});
+
+			return await runner.run(infoCommand, {
+				logger,
+				debugInfoProvider,
+				getDebugInfoFormatter: ({ pretty }) =>
+					createStyledDebugInfoFormatter({
+						textStyler: pretty ? textStyler : createPassthroughTextStyler(),
+					}),
+				clipboard,
+			});
 		}
 		case 'create-key': {
 			const [{ createCryptoKeyGenerator }, { createKeyCommand }] = await Promise.all([

packages/astro/src/cli/info/core/get-package-manager.ts

@@ -0,0 +1,44 @@
+import type { CommandExecutor } from '../../definitions.js';
+import type { PackageManager, PackageManagerUserAgentProvider } from '../definitions.js';
+
+interface Options {
+	packageManagerUserAgentProvider: PackageManagerUserAgentProvider;
+	commandExecutor: CommandExecutor;
+}
+
+export async function getPackageManager({
+	packageManagerUserAgentProvider,
+	commandExecutor,
+}: Options): Promise<PackageManager> {
+	const userAgent = packageManagerUserAgentProvider.getUserAgent();
+	if (!userAgent) {
+		const { createNoopPackageManager } = await import('../infra/noop-package-manager.js');
+		return createNoopPackageManager();
+	}
+	const specifier = userAgent.split(' ')[0];
+	const _name = specifier.substring(0, specifier.lastIndexOf('/'));
+	const name = _name === 'npminstall' ? 'cnpm' : _name;
+
+	switch (name) {
+		case 'pnpm': {
+			const { createPnpmPackageManager } = await import('../infra/pnpm-package-manager.js');
+			return createPnpmPackageManager({ commandExecutor });
+		}
+		case 'npm': {
+			const { createNpmPackageManager } = await import('../infra/npm-package-manager.js');
+			return createNpmPackageManager({ commandExecutor });
+		}
+		case 'yarn': {
+			const { createYarnPackageManager } = await import('../infra/yarn-package-manager.js');
+			return createYarnPackageManager({ commandExecutor });
+		}
+		case 'bun': {
+			const { createBunPackageManager } = await import('../infra/bun-package-manager.js');
+			return createBunPackageManager();
+		}
+		default: {
+			const { createNoopPackageManager } = await import('../infra/noop-package-manager.js');
+			return createNoopPackageManager();
+		}
+	}
+}

packages/astro/src/cli/info/core/info.ts

@@ -0,0 +1,29 @@
+import type { Logger } from '../../../core/logger/core.js';
+import { defineCommand } from '../../domain/command.js';
+import type { Clipboard, DebugInfoFormatter, DebugInfoProvider } from '../definitions.js';
+
+interface Options {
+	debugInfoProvider: DebugInfoProvider;
+	getDebugInfoFormatter: (options: { pretty: boolean }) => DebugInfoFormatter;
+	logger: Logger;
+	clipboard: Clipboard;
+}
+
+export const infoCommand = defineCommand({
+	help: {
+		commandName: 'astro info',
+		tables: {
+			Flags: [
+				['--help (-h)', 'See all available flags.'],
+				['--copy', 'Force copy of the output.'],
+			],
+		},
+		description:
+			'Reports useful information about your current Astro environment. Useful for providing information when opening an issue.',
+	},
+	async run({ debugInfoProvider, getDebugInfoFormatter, logger, clipboard }: Options) {
+		const debugInfo = await debugInfoProvider.get();
+		logger.info('SKIP_FORMAT', getDebugInfoFormatter({ pretty: true }).format(debugInfo));
+		await clipboard.copy(getDebugInfoFormatter({ pretty: false }).format(debugInfo));
+	},
+});

packages/astro/src/cli/info/definitions.ts

@@ -0,0 +1,35 @@
+import type { AstroConfig } from '../../types/public/index.js';
+import type { DebugInfo } from './domain/debug-info.js';
+
+export interface DebugInfoProvider {
+	get: () => Promise<DebugInfo>;
+}
+
+export interface DebugInfoFormatter {
+	format: (info: DebugInfo) => string;
+}
+
+export interface Clipboard {
+	copy: (text: string) => Promise<void>;
+}
+
+export interface PackageManager {
+	getName: () => string;
+	getPackageVersion: (name: string) => Promise<string | undefined>;
+}
+
+export interface AstroConfigResolver {
+	resolve: () => Promise<AstroConfig>;
+}
+
+export interface Prompt {
+	confirm: (input: { message: string; defaultValue?: boolean }) => Promise<boolean>;
+}
+
+export interface PackageManagerUserAgentProvider {
+	getUserAgent: () => string | null;
+}
+
+export interface NodeVersionProvider {
+	get: () => string;
+}

packages/astro/src/cli/info/domain/debug-info.ts

@@ -0,0 +1 @@
+export type DebugInfo = Array<[string, string | Array<string>]>;