-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat!: drop node 18 and 20 #14427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat!: drop node 18 and 20 #14427
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
a140052
feat: remove polyfill
florian-lefebvre f36affe
feat: misc
florian-lefebvre ddd093f
feat: version
florian-lefebvre 8443daf
chore: changeset
florian-lefebvre 935b8ed
feat: use import.meta.resolve
florian-lefebvre 74a056a
feat: use import.meta.resolve
florian-lefebvre 22a3f5a
Revert "feat: use import.meta.resolve"
florian-lefebvre 1d36ec6
feat: node 24
florian-lefebvre 5905b83
Merge branch 'next' into feat/drop-node-18
florian-lefebvre 49415b4
fix: pin wrangler
florian-lefebvre 547048a
Merge branch 'next' into feat/drop-node-18
florian-lefebvre 4fcff0e
Merge branch 'next' into feat/drop-node-18
florian-lefebvre e9d328c
Merge branch 'next' into feat/drop-node-18
florian-lefebvre 656bbde
fix: build
florian-lefebvre 12b9fad
Merge branch 'next' into feat/drop-node-18
florian-lefebvre 2b5fb20
Merge branch 'next' into feat/drop-node-18
florian-lefebvre 0746215
fix: path on windows
florian-lefebvre 997ad6b
feat: update cli entrypoint
florian-lefebvre d422fb4
fix: path
florian-lefebvre 85474ce
fix: path
florian-lefebvre 47e23be
feat: update version to node 22
florian-lefebvre 153b325
chore: format
florian-lefebvre a1c77b3
Discard changes to examples/basics/tsconfig.json
florian-lefebvre 8799ec6
Discard changes to examples/blog/tsconfig.json
florian-lefebvre 4e1b232
Discard changes to examples/container-with-vitest/tsconfig.json
florian-lefebvre ea0c05f
Discard changes to examples/framework-alpine/tsconfig.json
florian-lefebvre 55a862e
Discard changes to examples/framework-multiple/tsconfig.json
florian-lefebvre 0bba698
fix: remove 20 from ci
florian-lefebvre d2d604b
Update puny-poems-create.md
florian-lefebvre a2c53bb
Update puny-poems-create.md
florian-lefebvre 5fe601f
try fix db test
florian-lefebvre 637dd59
Revert "try fix db test"
florian-lefebvre 1285d95
wip
florian-lefebvre 6400b05
wip
florian-lefebvre 65fadd7
wip
florian-lefebvre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| '@astrojs/markdoc': minor | ||
| '@astrojs/preact': major | ||
| '@astrojs/svelte': major | ||
| '@astrojs/react': major | ||
| '@astrojs/solid-js': major | ||
| '@astrojs/mdx': major | ||
| 'create-astro': major | ||
| '@astrojs/prism': major | ||
| '@astrojs/upgrade': minor | ||
| 'astro': major | ||
| --- | ||
|
|
||
| Increases minimum Node.js version to 22.0.0 | ||
|
|
||
| Node 18 reached its End of Life in March 2025 and Node 20 is scheduled to reach its End of Life in April 2026. | ||
|
|
||
| Astro v6.0 drops Node 18 and Node 20 support entirely so that all Astro users can take advantage of Node's more modern features. | ||
|
|
||
| #### What should I do? | ||
|
|
||
| Check that both your development environment and your deployment environment are using **Node `22.0.0` or higher**. | ||
|
|
||
| 1. Check your local version of Node using: | ||
|
|
||
| ```sh | ||
| node -v | ||
| ``` | ||
|
|
||
| 2. Check your deployment environment's own documentation to verify that they support Node 22. | ||
|
|
||
| You can specify Node `22.0.0` for your Astro project either in a dashboard configuration setting or a `.nvmrc` file. | ||
|
|
||
| ```bash | ||
| # .nvmrc | ||
| 22.0.0 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 18.20.8 | ||
| 22.20.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| FROM node:18-bullseye | ||
| FROM node:22-bullseye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ | |
| "packages/*" | ||
| ], | ||
| "engines": { | ||
| "node": "^18.20.8 || ^20.3.0 || >=22.0.0" | ||
| "node": ">=22.0.0" | ||
| }, | ||
| "packageManager": "[email protected]", | ||
| "dependencies": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,27 +82,17 @@ export async function revalidateRemoteImage( | |
| }; | ||
| } | ||
|
|
||
| function webToCachePolicyRequest({ url, method, headers: _headers }: Request): CachePolicy.Request { | ||
| let headers: CachePolicy.Headers = {}; | ||
| // Be defensive here due to a cookie header bug in [email protected] + undici | ||
| try { | ||
| headers = Object.fromEntries(_headers.entries()); | ||
| } catch {} | ||
| function webToCachePolicyRequest({ url, method, headers }: Request): CachePolicy.Request { | ||
| return { | ||
| method, | ||
| url, | ||
| headers, | ||
| headers: Object.fromEntries(headers.entries()), | ||
| }; | ||
| } | ||
|
|
||
| function webToCachePolicyResponse({ status, headers: _headers }: Response): CachePolicy.Response { | ||
| let headers: CachePolicy.Headers = {}; | ||
| // Be defensive here due to a cookie header bug in [email protected] + undici | ||
| try { | ||
| headers = Object.fromEntries(_headers.entries()); | ||
| } catch {} | ||
| function webToCachePolicyResponse({ status, headers }: Response): CachePolicy.Response { | ||
| return { | ||
| status, | ||
| headers, | ||
| headers: Object.fromEntries(headers.entries()), | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires node 22 in the monorepo